Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20910

Fix dev-support/submit-patch.py by opening file with 'b' mode

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1
    • scripts
    • None

    Description

      
      
      hbase$ python3.6 dev-support/submit-patch.py
      INFO:submit-patch: Active branch: master
      INFO:submit-patch: Using tracking branch as base branch
      INFO:submit-patch: Base branch: origin/master
      INFO:submit-patch: Patch directory: /Users/asinghal/patches
      INFO:submit-patch: Patch name: master.patch
      Traceback (most recent call last):
       File "dev-support/submit-patch.py", line 253, in <module>
       f.write(diff.encode('utf8'))
      TypeError: write() argument must be str, not bytes
      

      tedyu@apache.org, FYI

      Attachments

        1. HBASE-20910.patch
          0.5 kB
          Ankit Singhal
        2. HBASE-20910_v1.patch
          0.8 kB
          Ankit Singhal

        Activity

          People

            ankit@apache.org Ankit Singhal
            ankit@apache.org Ankit Singhal
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: