Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20910

Fix dev-support/submit-patch.py by opening file with 'b' mode

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: scripts
    • Labels:
      None

      Description

      
      
      hbase$ python3.6 dev-support/submit-patch.py
      INFO:submit-patch: Active branch: master
      INFO:submit-patch: Using tracking branch as base branch
      INFO:submit-patch: Base branch: origin/master
      INFO:submit-patch: Patch directory: /Users/asinghal/patches
      INFO:submit-patch: Patch name: master.patch
      Traceback (most recent call last):
       File "dev-support/submit-patch.py", line 253, in <module>
       f.write(diff.encode('utf8'))
      TypeError: write() argument must be str, not bytes
      

      Ted Yu, FYI

        Attachments

        1. HBASE-20910.patch
          0.5 kB
          Ankit Singhal
        2. HBASE-20910_v1.patch
          0.8 kB
          Ankit Singhal

          Activity

            People

            • Assignee:
              ankit@apache.org Ankit Singhal
              Reporter:
              ankit@apache.org Ankit Singhal
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: