[HBASE-20884] Replace usage of our Base64 implementation with java.util.Base64

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 1.3.3, 1.4.6, 2.2.0, 1.2.7, 2.1.1, 2.0.2
• Hadoop Flags: Incompatible change, Reviewed

Release Note

Class org.apache.hadoop.hbase.util.Base64 has been removed in it's entirety from HBase 2+. In HBase 1, unused methods have been removed from the class and the audience was changed from Public to Private. This class was originally intended as an internal utility class that could be used externally but thinking since changed; these classes should not have been advertised as public to end-users.

This represents an incompatible change for users who relied on this implementation. An alternative implementation for affected clients is available at java.util.Base64 when using Java 8 or newer; be aware, it may encode/decode differently. For clients seeking to restore this specific implementation, it is available in the public domain for download at http://iharder.sourceforge.net/current/java/base64/

• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 13/Jul/18 14:31
• Updated: 04/Mar/19 09:08
• Resolved: 16/Jul/18 14:40

Description

We have a public domain implementation of Base64 that is copied into our code base and infrequently receives updates. We should replace usage of that with the new Java 8 java.util.Base64 where possible.

For the migration, I propose a phased approach.

• Deprecate on 1.x and 2.x to signal to users that this is going away.
• Replace usages on branch-2 and master with j.u.Base64
• Delete our implementation of Base64 on master.

Does this seem in line with our API compatibility requirements?

Issue Links

• causes: PHOENIX-4825 Replace usage of HBase Base64 implementation with java.util.Base64
• links to: Review Board (branch-1)
• links to: Review Board (master)