[HBASE-20583] SplitLogWorker should handle FileNotFoundException when split a wal

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.1, 1.2.7
• Component/s: wal
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 15/May/18 03:37
• Updated: 17/Aug/23 21:10
• Resolved: 18/May/18 06:41

Description

When a split task is finished, master will delete the wal first, then remove the task's zk node. So if master crashed after delelte the wal, the zk task node may be leaved on zk. When master resubmit this task, the task will failed by FileNotFoundException.

We also handle FileNotFoundException in WALSplitter. But not handle this in SplitLogWorker.

 

  try {
    in = getReader(path, reporter);
  } catch (EOFException e) {
    if (length <= 0) {
      // TODO should we ignore an empty, not-last log file if skip.errors
      // is false? Either way, the caller should decide what to do. E.g.
      // ignore if this is the last log in sequence.
      // TODO is this scenario still possible if the log has been
      // recovered (i.e. closed)
      LOG.warn("Could not open {} for reading. File is empty", path, e);
    }
    // EOFException being ignored
    return null;
  }
} catch (IOException e) {
  if (e instanceof FileNotFoundException) {
    // A wal file may not exist anymore. Nothing can be recovered so move on
    LOG.warn("File {} does not exist anymore", path, e);
    return null;
  }
}

// Here fs.getFileStatus may throw FileNotFoundException, too. We should handle this exception as the WALSplitter.getReader.
try {
  if (!WALSplitter.splitLogFile(walDir, fs.getFileStatus(new Path(walDir, filename)),
    fs, conf, p, sequenceIdChecker,
      server.getCoordinatedStateManager().getSplitLogWorkerCoordination(), factory)) {
    return Status.PREEMPTED;
  }
} 

 

 

Issue Links

• relates to: HBASE-20974 Backport HBASE-20583 (SplitLogWorker should handle FileNotFoundException when split a wal) to branch-1
• relates to: HBASE-28030 Adding unit test for FileNotFoundException when split a wal in SplitLogWorker

Sub-Tasks

• Backport HBASE-20583 (SplitLogWorker should handle FileNotFoundException when split a wal) to branch-1: Resolved