[HBASE-20574] prevRowLock seems not working

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: regionserver
• Assignee: Unassigned
• Reporter: Yi Zheng
• Created: 12/May/18 05:33
• Updated: 13/May/18 03:02

Description

In HRegion.java, getRowLockInternal using prevRowLock to check whether this lock is obtained before, but it may not work as imagine.

Because this parameter passed as the last lock the thread obtained, and the code always be like this:

for (byte[] rows: rowsToLock) {
    rowLock = getRowLockInternal(row, prevRowLock);
    if (rowLock != prevRowLock){  
        acquiredRowLocks.add(rowLock);                 
        prevRowLock = rowLock;        
    }
}

prevRowLock will never equal to the rowLockContext's lock in getRowLockInternal. I think this parameter is redundant.