[HBASE-20468] RPC quota requests ineffective due to not counting multi-actions

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Component/s: rpc
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 20/Apr/18 20:05
• Updated: 01/Aug/18 06:22
• Resolved: 24/Apr/18 01:28

Description

Was digging into a problem with ankit.singhal where setting RPC quotas on number of requests wasn't having any effect on a multi-Get

Ankit did enough digging to find that this was because each RPC was being treated as one request instead of the number of requests contained within the RPC itself.

Thinking as an operator, this is a pretty ineffective control because a user could just craft their API usage easily to work around any kind of limits I want to set to control their impact on the system. TimeBasedLimiter is assuming that one call to the quota code can only count as one request which I think is just wrong.

Issue Links

• duplicates: HBASE-19924 hbase rpc throttling does not work for multi() with request count rater.