[HBASE-20447] Only fail cacheBlock if block collisions aren't related to next block metadata

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.3, 2.0.0
• Fix Version/s: 3.0.0-alpha-1, 2.1.0, 1.4.5
• Component/s: BlockCache, BucketCache
• Hadoop Flags: Reviewed
• Assignee: Zach York
• Reporter: Zach York
• Created: 18/Apr/18 00:17
• Updated: 13/Sep/23 11:43
• Resolved: 15/May/18 00:17

Description

This is the issue I was originally having here: http://mail-archives.apache.org/mod_mbox/hbase-dev/201802.mbox/%3CCAN+qs_Pav=[e-mail]%3E

 

When we pread, we don't force the read to read all of the next block header.
However, when we get into a race condition where two opener threads try to
cache the same block and one thread read all of the next block header and the other one didn't, it will fail the open process. This is especially important
in a splitting case where it will potentially fail the split process.
Instead, in the caches, we should only fail if the required blocks are different.
 

Issue Links

• relates to: HBASE-22433 Corrupt hfile data
• relates to: HBASE-20789 TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
• links to: Review Board (branch-1)
• links to: Review Board (master)