[HBASE-20442] clean up incorrect use of commons-collections 3

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 3.0.0-alpha-1, 2.0.0
• Component/s: dependencies, thirdparty
• Assignee: Sean Busbey
• Reporter: Sean Busbey
• Created: 17/Apr/18 21:08
• Updated: 01/Aug/18 06:23
• Resolved: 20/Apr/18 13:48

Description

we upgraded to commons-collections 4 in HBASE-18704 and then to an internal-only hbase-thirdparty version in HBASE-20223, but we've regressed:

$ git grep "import org.apache.commons.collections"
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:import org.apache.commons.collections.MapUtils;
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowMutations.java:import org.apache.commons.collections.CollectionUtils;
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:import org.apache.commons.collections.CollectionUtils;
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.CollectionUtils;
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.MapUtils;

Issue Links

• blocks: HBASE-20443 Use checkstyle to ban imports from commons-collections 3