[HBASE-20199] Add test to prevent further permission regression around table flush and snapshot

• Type: Task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 14/Mar/18 16:07
• Updated: 09/Apr/18 05:42
• Resolved: 28/Mar/18 00:29

Description

There is already a test for that in TestAccessController- https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java#L809, - however, those tests are hacked to not run the operations but the AC hooks directly. for eg. instead of triggering flush, it just runs ACCESS_CONTROLLER.preTableFlush(). It's not possible/good to change just a few tests there given that will break the overall design and make things harder to maintain.

The new test should go in TestAdminOnlyOperations (and the test class name should probably be changed to TestRpcAccessChecks).

Issue Links

• relates to: HBASE-20185 Fix ACL check for MasterRpcServices#execProcedure