Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20185

Fix ACL check for MasterRpcServices#execProcedure

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Mailing thread ref: http://mail-archives.apache.org/mod_mbox/hbase-dev/201803.mbox/%3CCAAjhxrriGy_UXpC4iHCSyBB18iAbjU3Y2%2BnjQ-66i9kPPCrPRQ%40mail.gmail.com%3E

      TLDR; HBASE-19400 messed up perms required for flushing a table.


      Looks like flush and snapshot procedures are already doing permissions check as part of preTableFlush/preSnapshot hooks. However, LogRollMasterProcedureManager is missing access checks (Josh Elser, can someone look at it?)
       
      With that, it makes no sense to put an ADMIN perm requirement which was added by me in HBASE-19400. Removing it.
      However, to make things better for future, i have made few design changes which will ensure 1) perm checks don't slip by mistake, 2) a suitable placeholder for checks for flush & snapshot when we remove AccessController for good.
       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                appy Appy
                Reporter:
                appy Appy
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: