[HBASE-20133] Calculate correct assignment and build region movement plans for mis-placed regions in one pass

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1
• Component/s: rsgroup
• Hadoop Flags: Reviewed
• Assignee: Xiang Li
• Reporter: Xiang Li
• Created: 05/Mar/18 15:03
• Updated: 28/Mar/18 02:50
• Resolved: 10/Mar/18 15:10

Description

In RSGroupBasedLoadBalancer#balanceCluster(clusterState), the logic could be improved:

correctAssignment() builds a map for mis-placed and placed regions. For mis-placed regions, the key(ServerName) is BOGUS_SERVER_NAME. Then the logic gets those mis-paced regions out and calls findServerForRegion() several times to find out the current host server, in order to build RegionPlan for movement.

Some logic in correctAssignment() and findServerForRegion() could be merged so as to build both corrected assignment and RegionPlan for mis-placed region in one pass. As a result, findServerForRegion() could be removed if I get it correctly.