Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20108

`hbase zkcli` falls into a non-interactive prompt after HBASE-15199

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Usability
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      This issue fixes a runtime dependency issues where JLine is not made available on the classpath which causes the ZooKeeper CLI to appear non-interactive. JLine was being made available unintentionally via the JRuby jar file on the classpath for the HBase shell. While the JRuby jar is not always present, the fix made here was to selectively include the JLine dependency on the zkcli command's classpath.
      Show
      This issue fixes a runtime dependency issues where JLine is not made available on the classpath which causes the ZooKeeper CLI to appear non-interactive. JLine was being made available unintentionally via the JRuby jar file on the classpath for the HBase shell. While the JRuby jar is not always present, the fix made here was to selectively include the JLine dependency on the zkcli command's classpath.

      Description

      HBASE-15199 pulls the jruby-complete jar out of the normal classpath for commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for its nice shell-like usage.

      The problem is that this uncovered a bug where we're not explicitly bundling a version of jline to make sure that hbase zkcli actually works. As long as we're expecting zkcli to be there, we should provide jline on the classpath to make sure the users get a real cli.

      Thanks to Sergey Soldatov for getting to the bottom of it quickly.

        Attachments

        1. HBASE-20108.001.branch-2.patch
          0.7 kB
          Josh Elser
        2. HBASE-20108.002.branch-2.patch
          3 kB
          Josh Elser
        3. HBASE-20108.003.branch-2.patch
          4 kB
          Josh Elser

          Activity

            People

            • Assignee:
              elserj Josh Elser
              Reporter:
              elserj Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: