[HBASE-19981] Boolean#getBoolean is used to parse value

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.2, 1.4.2, 1.2.7
• Hadoop Flags: Reviewed
• Assignee: Janos Gub
• Reporter: Ted Yu
• Created: 12/Feb/18 17:27
• Updated: 01/Aug/18 06:22
• Resolved: 12/Feb/18 21:09

Description

In HColumnDescriptor of branch-1:

          value.set(Bytes.toBytes(
              Boolean.getBoolean(Bytes.toString(value.get()))

According to https://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#getBoolean(java.lang.String):

Returns true if and only if the system property named by the argument exists and is equal to the string "true"

This was not the intention of the quoted code.

This was discovered by Fortify.