[HBASE-19979] ReplicationSyncUp tool may leak Zookeeper connection

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.2, 2.0.0-beta-2, 1.4.2, 2.0.0
• Component/s: Replication
• Hadoop Flags: Reviewed
• Assignee: Pankaj Kumar
• Reporter: Pankaj Kumar
• Created: 12/Feb/18 14:01
• Updated: 01/Feb/19 20:00
• Resolved: 13/Feb/18 17:03

Description

ReplicationSyncUp tool may leak Zookeeper connection in the following code snippet,

    try {
      int numberOfOldSource = 1; // default wait once
      while (numberOfOldSource > 0) {
        Thread.sleep(SLEEP_TIME);
        numberOfOldSource = manager.getOldSources().size();
      }
    } catch (InterruptedException e) {
      System.err.println("didn't wait long enough:" + e);
      return (-1);
    }

    manager.join();
    zkw.close();

ZooKeeperWatcher will not be closed in case of InterruptedException.