[HBASE-19972] Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-2, 1.4.2, 2.0.0
• Component/s: Replication
• Hadoop Flags: Reviewed
• Assignee: Zheng Hu
• Reporter: Zheng Hu
• Created: 11/Feb/18 06:07
• Updated: 17/Jun/22 17:29
• Resolved: 12/Feb/18 07:20

Description

As Apache9 said in HBASE-12091. 

In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException except 

TableNotFoundException,   actually,  should rethrow the exception. 

try {
      Connection connection = getConnection();
      table = connection.getTable(tableName);
      for (List<Row> rows : allRows) {
        table.batch(rows);
      }
    } catch (RetriesExhaustedWithDetailsException rewde) {
      for (Throwable ex : rewde.getCauses()) {
        if (ex instanceof TableNotFoundException) {
          throw new TableNotFoundException("'"+tableName+"'");
        }
      }
    } 

Issue Links

• is broken by: HBASE-12091 Optionally ignore edits for dropped tables for replication.