Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19651

Remove LimitInputStream

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-1, 2.0.0-beta-2
    • Fix Version/s: 2.0.0-beta-1, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      HBase had copied from guava the file LmiitedInputStream. This commit removes the copied file in favor of (our internal, shaded) guava's ByteStreams.limit. Guava 14.0's LIS noted: "Use ByteStreams.limit(java.io.InputStream, long) instead. This class is scheduled to be removed in Guava release 15.0."
      Show
      HBase had copied from guava the file LmiitedInputStream. This commit removes the copied file in favor of (our internal, shaded) guava's ByteStreams.limit. Guava 14.0's LIS noted: "Use ByteStreams.limit(java.io.InputStream, long) instead. This class is scheduled to be removed in Guava release 15.0."

      Description

      Let us "drink our own champagne" and use the existing Apache Commons BoundedInputStream instead.

        Attachments

        1. HBASE-19651.1.patch
          6 kB
          David Mollitor
        2. HBASE-19651.2.patch
          7 kB
          David Mollitor
        3. HBASE-19651.3.patch
          6 kB
          David Mollitor
        4. HBASE-19651.4.patch
          7 kB
          David Mollitor
        5. HBASE-19651.5.patch
          7 kB
          David Mollitor
        6. HBASE-19651.6.patch
          8 kB
          David Mollitor

          Issue Links

          duplicates

          Task - A task that needs to be done. HBASE-10255 Remove dependency on LimitInputStream

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-18722 Replace copied guava code w/ pointer to the (shaded) lib

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

            Activity

              People

              • Assignee:
                belugabehr David Mollitor
                Reporter:
                belugabehr David Mollitor
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: