[HBASE-19319] Fix bug in synchronizing over ProcedureEvent

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Assignee: Apekshit Sharma
• Reporter: Apekshit Sharma
• Created: 21/Nov/17 23:41
• Updated: 01/Aug/18 06:20
• Resolved: 27/Nov/17 20:10

Description

Following synchronizes over local variable rather than the original ProcedureEvent object. Clearly a bug since this code block won't follow exclusion with many of the synchronized methods in ProcedureEvent class.

 @Override
  public void wakeEvents(final int count, final ProcedureEvent... events) {
    final boolean traceEnabled = LOG.isTraceEnabled();
    schedLock();
    try {
      int waitingCount = 0;
      for (int i = 0; i < count; ++i) {
        final ProcedureEvent event = events[i];
        synchronized (event) {
          if (!event.isReady()) {

Issue Links

• links to: Review Board (master)