[HBASE-19319] Fix bug in synchronizing over ProcedureEvent - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 2.0.0-beta-1, 2.0.0
Component/s: None
Labels:
None

Description

Following synchronizes over local variable rather than the original ProcedureEvent object. Clearly a bug since this code block won't follow exclusion with many of the synchronized methods in ProcedureEvent class.

 @Override
  public void wakeEvents(final int count, final ProcedureEvent... events) {
    final boolean traceEnabled = LOG.isTraceEnabled();
    schedLock();
    try {
      int waitingCount = 0;
      for (int i = 0; i < count; ++i) {
        final ProcedureEvent event = events[i];
        synchronized (event) {
          if (!event.isReady()) {