[HBASE-19249] test for "hbase antipatterns" should check _count_ of occurance rather than text of

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.4.0, 1.3.2, 2.0.0-beta-1, 1.1.13, 2.0.0, 1.2.7
• Component/s: build
• Assignee: Sean Busbey
• Reporter: Sean Busbey
• Created: 13/Nov/17 22:01
• Updated: 01/Feb/19 19:57
• Resolved: 14/Nov/17 05:29

Description

appy noticed on HBASE-18624 that our check for Hadoop annotations failed to flag a use.

looking at our check:

  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
  if [[ ${warnings} -gt 0 ]]; then
    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
    ((result=result+1))
  fi

That should have been a "grep -c" and not a "grep". So we've been falsely giving a negative on all these checks.