Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19249

test for "hbase antipatterns" should check _count_ of occurance rather than text of

    XMLWordPrintableJSON

    Details

      Description

      Apekshit Sharma noticed on HBASE-18624 that our check for Hadoop annotations failed to flag a use.

      looking at our check:

      
        warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
        if [[ ${warnings} -gt 0 ]]; then
          add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
          ((result=result+1))
        fi
      

      That should have been a "grep -c" and not a "grep". So we've been falsely giving a negative on all these checks.

        Attachments

        1. HBASE-19249.0.patch
          2 kB
          Sean Busbey

          Activity

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: