[HBASE-19194] TestRSGroupsBase has some always false checks

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.4.0, 2.0.0
• Component/s: rsgroup, test
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Mike Drob
• Created: 07/Nov/17 03:09
• Updated: 04/Oct/19 14:59
• Resolved: 08/Nov/17 17:43

Description

Discovered via error-prone analysis:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile (default-testCompile) on project hbase-rsgroup: Compilation failure: Compilation failure:
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40] [CollectionIncompatibleType] Argument 'region' should not be passed to this method; its type RegionInfo is not compatible with its collection's type argument String
[ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65] [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to this method; its type String is not compatible with its collection's type argument RegionInfo
[ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)

Both of these are checks to List<T>.contains with an element of the wrong type so they will always return false. The first is an optimization that we can probably live without (or short circuit on the Master, at least) the second is an assertion that will never fail, rendering the test ineffective.

Issue Links

• relates to: HBASE-15631 Backport Regionserver Groups (HBASE-6721) to branch-1