[HBASE-19153] LruBlockCache cache too big blocks logic error

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Not A Bug
• Affects Version/s: 2.0.0-alpha-3
• Component/s: BlockCache
• Assignee: Unassigned
• Reporter: Zhang Quanjin
• Created: 02/Nov/17 01:51
• Updated: 01/Aug/18 06:22
• Resolved: 03/Nov/17 01:10

Description

The latest version of LruBolckCache, I found the code logic of cache too big bolcks is inconsistent with annotation.
If follow the notes, the code should look like this:

if (buf.heapSize() > maxBlockSize) {
// If there are a lot of blocks that are too
// big this can make the logs way too noisy.
// So we log 2%
if (stats.failInsert() % 50 != 0)

{ return; }

LOG.warn("Trying to cache too large a block "
+ cacheKey.getHfileName() + " @ "
+ cacheKey.getOffset()
+ " is " + buf.heapSize()
+ " which is larger than " + maxBlockSize);

}