[HBASE-19035] Miss metrics when coprocessor use region scanner to read data

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0, 2.0.0-beta-1, 2.0.0

Release Note

1. Move read requests count to region level. Because RegionScanner is exposed to CP.
2. Update write requests count in processRowsWithLocks.
3. Remove requestRowActionCount in RSRpcServices. This metric can be computed by region's readRequestsCount and writeRequestsCount.

• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 18/Oct/17 10:15
• Updated: 03/Jun/21 02:44
• Resolved: 28/Nov/17 19:57

Description

Region interface is exposed to coprocessor. So coprocessor use getScanner to get a region scanner to read data. But the scan metrics was only updated in region server level. So we will miss some scan metrics for the read from coprocessor.

Region Operation	When to update requests metric
get	update read metric in nextRaw()
put	update write metric in batchMutate()
delete	update write metric in batchMutate()
increment	update read metric by get() and update write metric in doDelta()
append	update read metric by get() and update write metric in doDelta()
mutateRow	update write metric in processRowsWithLocks()
mutateRowsWithLocks	update write metric in processRowsWithLocks()
batchMutate	update write metric in batchMutate()
checkAndMutate	update read metric by get() and update write metric by mutateRow()
checkAndRowMutate	update read metric by get() and update write metric by doBatchMutate()
processRowsWithLocks	update write metric in processRowsWithLocks()

1. Move read requests to region level. Because RegionScanner exposed to CP.
2. Update write requests count in processRowsWithLocks. This was missed in previous implemenation, too.
3. Remove requestRowActionCount in RSRpcServices. This metric can be computed by region's readRequestsCount and writeRequestsCount.

Upload to review board: https://reviews.apache.org/r/63579/

Issue Links

• causes: HBASE-25967 The readRequestsCount does not calculate when the outResults is empty
• is related to: HBASE-18469 Correct RegionServer metric of totalRequestCount

Sub-Tasks

• Backport to branch-1 HBASE-19035 Miss metrics when coprocessor use region scanner to read data: Resolved