[HBASE-18981] Address issues found by error-prone in hbase-client

• Type: Sub-task
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-4, 2.0.0
• Labels: quota
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 10/Oct/17 18:28
• Updated: 17/Jun/22 17:11
• Resolved: 10/Oct/17 19:52

Description

I thought this was something that we would already catch in findbugs, but maybe not?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project hbase-client: Compilation failure
[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5] [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or handle the remaining cases: GLOBAL_BYPASS
[ERROR]     (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)

cc: elserj, this looks like it is part of quota code. I'm happy to add a trivial patch to error on the missing case, but want somebody with more contextual knowledge to look at it.