[HBASE-18893] Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using ModifyTableProcedure

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-4, 2.0.0
• Component/s: Coprocessors, master
• Hadoop Flags: Incompatible change

Release Note

The RPC calls for Add/Modify/DeleteColumn have been removed and are now backed by ModifyTable functionality. The corresponding permissions in AccessController have been removed as well.

The shell already bypassed these RPCs and used ModifyTable directly, and thus would not be getting these permission checks, this change brings the rest of the RPC inline with that.

Coprocessor hooks for pre/post Add/Modify/DeleteColumn have likewise been removed. Coprocessors needing to take special actions on schema change should instead process ModifyTable events (which they should have been doing already, but it was easy for developers to miss this nuance).

• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 27/Sep/17 21:40
• Updated: 16/Nov/18 11:29
• Resolved: 24/Oct/17 01:18

Description

The shell changed from using separate add/modify/delete column calls to funneling everything through modify table for performance reasons. We know that using modify table works for everything. Let's drop the old code for Add/Modify/Delete Column so that we have a lower maintenance burden and fewer code paths to reason about.

-------- Was: shell 'alter' command no longer distinguishes column add/modify/delete

After HBASE-15641 all 'alter' commands go through a single modifyTable call at the end, so we no longer can easily distinguish add, modify, and delete column events. This potentially affects coprocessors that needed the update notifications for new or removed columns.

Let's let the shell still make separate behaviour calls like it did before without undoing the batching that seems pretty useful.

Issue Links

• is related to: HBASE-21487 Concurrent modify table ops can lead to unexpected results