Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18853

hbase-protocol-shaded includes protobuf (since we moved to hbase-thirdparty)

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-4, 2.0.0
    • Component/s: thirdparty
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I didn't follow my own comment when I added hbase-thirdparty hbase-shaded-protobuf to hbase-shaded-protocol as a dependency instead of original protobuf. It meant that our jar had protobuf bundled up inside it.

      Change is small, and I don't think we were actually using the non-shaded protobuf anywhere, but if anyone was, it'd make for interesting issue to debug. Let me see if it breaks anything...

      (Found by our Vikram Srivastava on internal deploy...)

        Attachments

        1. HBASE-18853.master.002.patch
          3 kB
          Michael Stack
        2. HBASE-18853.master.001.patch
          1 kB
          Michael Stack

          Activity

            People

            • Assignee:
              stack Michael Stack
              Reporter:
              stack Michael Stack

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment