Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18766

Make TableSnapshotScanner Audience Private

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-3
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Tags:
      beginner

      Description

      From HBASE-10462 API cleanup. TableSnapshotScanner should be Audience Private. It should not be public. See HBASE-10462 for Enis Soztutar rationale. If private, then there needs to be a way to construct it. It is awkward since we normally construct 'Table' by getting one from a Connection. Enis suggests:

      Maybe we can do a SnapshotConnection which returns a ConnectionTable, which returns the scanner. Since connection is the factory to everything, I think this approach is the most clean.

      Sounds good.

        Issue Links

          Activity

          Hide
          chia7712 Chia-Ping Tsai added a comment -

          stack Our docs say If you are looking to contribute to Apache HBase, look for issues in JIRA tagged with the label 'beginner'., so I add the "beginner" label.

          Show
          chia7712 Chia-Ping Tsai added a comment - stack Our docs say If you are looking to contribute to Apache HBase, look for issues in JIRA tagged with the label 'beginner' ., so I add the "beginner" label.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 4m 35s master passed
          +1 compile 0m 40s master passed
          +1 checkstyle 0m 48s master passed
          +1 mvneclipse 0m 16s master passed
          +1 shadedjars 5m 30s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 2m 52s master passed
          +1 javadoc 0m 35s master passed
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 44s the patch passed
          +1 javac 0m 44s the patch passed
          +1 checkstyle 0m 48s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 45m 41s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 2m 58s the patch passed
          +1 javadoc 0m 34s the patch passed
          -1 unit 89m 53s hbase-server in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          157m 9s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.master.TestMasterMetricsWrapper
            org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.TestMasterFailover
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics
            org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
            org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner
            org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
            org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
            org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks
            org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates
            org.apache.hadoop.hbase.master.TestMaster
            org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient
            org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
            org.apache.hadoop.hbase.TestAcidGuarantees
            org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency
            org.apache.hadoop.hbase.master.TestRestartCluster
            org.apache.hadoop.hbase.master.TestWarmupRegion
            org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions
            org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents
            org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure
            org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
            org.apache.hadoop.hbase.master.procedure.TestFastFailOnProcedureNotRegistered
            org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
            org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
            org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure
            org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18766
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886969/HBASE-18766.v0.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux f36aab7a87e9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 8bbfc83
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8619/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8619/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8619/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 4m 35s master passed +1 compile 0m 40s master passed +1 checkstyle 0m 48s master passed +1 mvneclipse 0m 16s master passed +1 shadedjars 5m 30s branch has no errors when building our shaded downstream artifacts. +1 findbugs 2m 52s master passed +1 javadoc 0m 35s master passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 45m 41s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 2m 58s the patch passed +1 javadoc 0m 34s the patch passed -1 unit 89m 53s hbase-server in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 157m 9s Reason Tests Timed out junit tests org.apache.hadoop.hbase.master.TestMasterMetricsWrapper   org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure   org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure   org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.TestMasterFailover   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics   org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster   org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner   org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures   org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS   org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks   org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates   org.apache.hadoop.hbase.master.TestMaster   org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient   org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient   org.apache.hadoop.hbase.TestAcidGuarantees   org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency   org.apache.hadoop.hbase.master.TestRestartCluster   org.apache.hadoop.hbase.master.TestWarmupRegion   org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions   org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents   org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure   org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure   org.apache.hadoop.hbase.master.procedure.TestFastFailOnProcedureNotRegistered   org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas   org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure   org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure   org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure   org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 JIRA Issue HBASE-18766 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886969/HBASE-18766.v0.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux f36aab7a87e9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 8bbfc83 Default Java 1.8.0_144 findbugs v3.1.0-RC3 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8619/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8619/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8619/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          chia7712 Chia-Ping Tsai added a comment -

          Let me put this in alpha3? stack

          Show
          chia7712 Chia-Ping Tsai added a comment - Let me put this in alpha3? stack
          Hide
          stack stack added a comment -

          Pushed to master and branch-2. Don't we need a follow-on so folks have a means of obtaining a TableSnapshotScanner as per the Enis suggestion? Create a new issue Chia-Ping Tsai ? Thanks.

          Show
          stack stack added a comment - Pushed to master and branch-2. Don't we need a follow-on so folks have a means of obtaining a TableSnapshotScanner as per the Enis suggestion? Create a new issue Chia-Ping Tsai ? Thanks.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3716 (See https://builds.apache.org/job/HBase-Trunk_matrix/3716/)
          HBASE-18766 Make TableSnapshotScanner Audience Private (stack: rev 9c5b03acd72713f1a9956086ad0a6f4b389deaae)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3716 (See https://builds.apache.org/job/HBase-Trunk_matrix/3716/ ) HBASE-18766 Make TableSnapshotScanner Audience Private (stack: rev 9c5b03acd72713f1a9956086ad0a6f4b389deaae) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #515 (See https://builds.apache.org/job/HBase-2.0/515/)
          HBASE-18766 Make TableSnapshotScanner Audience Private (stack: rev 296bb0054073ad295e57913aa2a01d8fb604bf9e)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #515 (See https://builds.apache.org/job/HBase-2.0/515/ ) HBASE-18766 Make TableSnapshotScanner Audience Private (stack: rev 296bb0054073ad295e57913aa2a01d8fb604bf9e) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java

            People

            • Assignee:
              chia7712 Chia-Ping Tsai
              Reporter:
              stack stack
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development