[HBASE-18733] [compat 1-2] Hide WALKey

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-3, 2.0.0
• Component/s: API
• Hadoop Flags: Incompatible change
• Release Note: WALKey, @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATION), changed a bunch for 2.0.0. See below. We figured it ok hiding it since it should be internals anyway -- only we should be making them.
• Assignee: Sean Busbey
• Reporter: Michael Stack
• Created: 01/Sep/17 01:07
• Updated: 21/Mar/18 22:12
• Resolved: 12/Sep/17 20:13

Description

It has all the below issues and it uses our internal PB. See head of class where it says it should go away...

hbase-server-1.0.0.jar, WALEdit.class
package org.apache.hadoop.hbase.regionserver.wal
[−] WALEdit.getCompaction ( Cell kv ) [static] : WALProtos.CompactionDescriptor 1
org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor;
Change Effect
1 Return value type has been changed from org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. This method has been removed because the return type is part of the method signature. A client program may be interrupted by NoSuchMethodError exception.

[+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : WALProtos.FlushDescriptor 1
[+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : WALProtos.RegionEventDescriptor 1

hbase-server-1.0.0.jar, WALKey.class
package org.apache.hadoop.hbase.wal
[+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : WALProtos.WALKey.Builder 1

Issue Links

• is related to: HBASE-16478 Rename WALKey in PB to WALEdit