Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18622 Mitigate API compatibility concerns between branch-1 and branch-2
  3. HBASE-18731

[compat 1-2] Mark protected methods of QuotaSettings that touch Protobuf internals as IA.Private

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      The following methods in QuotaSettings were annotated InterfaceAudience.Private; they are for internal use only in hbase-2.0.0

      buildSetQuotaRequestProto(final QuotaSettings settings)
      setupSetQuotaRequest(SetQuotaRequest.Builder builder)

      Note that there were versions of these methods in HBase 1.y that used classes in the {{org.apache.hadoop.hbase.protobuf.generated}} package. That package no longer exists as a part of our cleanup of protobufs from our public facing API and the related methods have been removed.
      Show
      The following methods in QuotaSettings were annotated InterfaceAudience.Private; they are for internal use only in hbase-2.0.0 buildSetQuotaRequestProto(final QuotaSettings settings) setupSetQuotaRequest(SetQuotaRequest.Builder builder) Note that there were versions of these methods in HBase 1.y that used classes in the {{org.apache.hadoop.hbase.protobuf.generated}} package. That package no longer exists as a part of our cleanup of protobufs from our public facing API and the related methods have been removed.

      Description

      QuotaSettings is Audience public. The param for setupSetQuotaRequest moved to package org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.SetQuotaRequest. QuotaSettings was added in 1.1.

      Is QuotaSettings for use by anyone but our CPEP?

        Attachments

        1. HBASE-18731.0.patch
          1 kB
          Sean Busbey
        2. HBASE-18731-branch-1.v1.patch
          2 kB
          Sean Busbey

          Activity

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              stack Michael Stack
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: