Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18723

[pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-3
    • Component/s: pom
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Purged a bunch of dependencies included but unused. Added reference to dependencies we do use but did not list (transitively included). Purged all but junit from parent pom dependency set and did explicit include in modules instead; not all modules need mockito, etc. Still work to do: grey area around hadoop and its transitive includes need cleanup still to make the dependency:analyze runs clean. Also figure how to purge junit from parent dependency list.
      Show
      Purged a bunch of dependencies included but unused. Added reference to dependencies we do use but did not list (transitively included). Purged all but junit from parent pom dependency set and did explicit include in modules instead; not all modules need mockito, etc. Still work to do: grey area around hadoop and its transitive includes need cleanup still to make the dependency:analyze runs clean. Also figure how to purge junit from parent dependency list.

      Description

      Do a pass over our poms. They are sloppy including unused jars and not listing actually used dependencies. Undo 'required' dependencies like junit and mockito; not all modules need these anymore.

      This cleanup motivated by failures up on jenkins where a build step is not finding transitive includes; explicit mention is needed (See failures in HBASE-18674).

        Issue Links

          Activity

          Hide
          stack stack added a comment -

          .001

          Do a pass with dependency:analyze; remove unused and
          explicity list the dependencies we exploit

          Remove the parent dependencies set which had junit, mockito,
          log4j, and findbugs annotations. Listing in parent set meant
          these libs were dependencies for all modules which in
          practice was not the case. Edited all modules so those that
          need any from this parent set now do explicit listing.

          Ran the dependency:analyze over the project. Acted on most
          suggested removals and requests for explicit listing. Some
          grey areas remain around transitives that come in with
          hadoop -needs better excludes, another project- and that
          the dependency:analyze tool is not always accurate in its
          reporting.

          Show
          stack stack added a comment - .001 Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit Remove the parent dependencies set which had junit, mockito, log4j, and findbugs annotations. Listing in parent set meant these libs were dependencies for all modules which in practice was not the case. Edited all modules so those that need any from this parent set now do explicit listing. Ran the dependency:analyze over the project. Acted on most suggested removals and requests for explicit listing. Some grey areas remain around transitives that come in with hadoop - needs better excludes, another project - and that the dependency:analyze tool is not always accurate in its reporting.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 45s Maven dependency ordering for branch
          +1 mvninstall 3m 52s master passed
          +1 compile 10m 28s master passed
          +1 mvneclipse 7m 30s master passed
          +1 javadoc 7m 35s master passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 10m 55s the patch passed
          +1 compile 10m 27s the patch passed
          +1 javac 10m 27s the patch passed
          +1 mvneclipse 7m 23s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 33s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 20s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 javadoc 9m 7s the patch passed
          +1 unit 0m 8s hbase-error-prone in the patch passed.
          -1 unit 0m 29s hbase-protocol-shaded in the patch failed.
          +1 unit 2m 19s hbase-common in the patch passed.
          +1 unit 0m 10s hbase-metrics-api in the patch passed.
          +1 unit 0m 22s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 16s hbase-metrics in the patch passed.
          +1 unit 0m 26s hbase-hadoop2-compat in the patch passed.
          -1 unit 0m 10s hbase-replication in the patch failed.
          +1 unit 0m 25s hbase-prefix-tree in the patch passed.
          +1 unit 3m 0s hbase-procedure in the patch passed.
          +1 unit 88m 15s hbase-server in the patch passed.
          +1 unit 8m 1s hbase-mapreduce in the patch passed.
          +1 unit 0m 13s hbase-resource-bundle in the patch passed.
          +1 unit 1m 48s hbase-thrift in the patch passed.
          +1 unit 0m 32s hbase-rsgroup in the patch passed.
          +1 unit 7m 1s hbase-shell in the patch passed.
          -1 unit 0m 28s hbase-endpoint in the patch failed.
          +1 unit 9m 2s hbase-backup in the patch passed.
          +1 unit 0m 31s hbase-it in the patch passed.
          +1 unit 1m 2s hbase-examples in the patch passed.
          +1 unit 3m 21s hbase-rest in the patch passed.
          -1 unit 0m 20s hbase-external-blockcache in the patch failed.
          +1 unit 4m 17s hbase-spark in the patch passed.
          +1 unit 0m 22s hbase-spark-it in the patch passed.
          +1 unit 0m 21s hbase-shaded in the patch passed.
          +1 unit 0m 19s hbase-shaded-check-invariants in the patch passed.
          +1 unit 0m 48s hbase-client-project in the patch passed.
          -1 unit 0m 16s root in the patch failed.
          +1 asflicense 6m 22s The patch does not generate ASF License warnings.
          245m 28s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884596/HBASE-18723.master.001.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux 23f7720ae6e4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 53c9516
          Default Java 1.8.0_144
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-protocol-shaded.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-replication.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-endpoint.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-external-blockcache.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8407/testReport/
          modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8407/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 3m 52s master passed +1 compile 10m 28s master passed +1 mvneclipse 7m 30s master passed +1 javadoc 7m 35s master passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 10m 55s the patch passed +1 compile 10m 27s the patch passed +1 javac 10m 27s the patch passed +1 mvneclipse 7m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 33s The patch has no ill-formed XML file. +1 hadoopcheck 33m 20s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 javadoc 9m 7s the patch passed +1 unit 0m 8s hbase-error-prone in the patch passed. -1 unit 0m 29s hbase-protocol-shaded in the patch failed. +1 unit 2m 19s hbase-common in the patch passed. +1 unit 0m 10s hbase-metrics-api in the patch passed. +1 unit 0m 22s hbase-hadoop-compat in the patch passed. +1 unit 0m 16s hbase-metrics in the patch passed. +1 unit 0m 26s hbase-hadoop2-compat in the patch passed. -1 unit 0m 10s hbase-replication in the patch failed. +1 unit 0m 25s hbase-prefix-tree in the patch passed. +1 unit 3m 0s hbase-procedure in the patch passed. +1 unit 88m 15s hbase-server in the patch passed. +1 unit 8m 1s hbase-mapreduce in the patch passed. +1 unit 0m 13s hbase-resource-bundle in the patch passed. +1 unit 1m 48s hbase-thrift in the patch passed. +1 unit 0m 32s hbase-rsgroup in the patch passed. +1 unit 7m 1s hbase-shell in the patch passed. -1 unit 0m 28s hbase-endpoint in the patch failed. +1 unit 9m 2s hbase-backup in the patch passed. +1 unit 0m 31s hbase-it in the patch passed. +1 unit 1m 2s hbase-examples in the patch passed. +1 unit 3m 21s hbase-rest in the patch passed. -1 unit 0m 20s hbase-external-blockcache in the patch failed. +1 unit 4m 17s hbase-spark in the patch passed. +1 unit 0m 22s hbase-spark-it in the patch passed. +1 unit 0m 21s hbase-shaded in the patch passed. +1 unit 0m 19s hbase-shaded-check-invariants in the patch passed. +1 unit 0m 48s hbase-client-project in the patch passed. -1 unit 0m 16s root in the patch failed. +1 asflicense 6m 22s The patch does not generate ASF License warnings. 245m 28s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884596/HBASE-18723.master.001.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux 23f7720ae6e4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 53c9516 Default Java 1.8.0_144 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-protocol-shaded.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-replication.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-endpoint.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-hbase-external-blockcache.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8407/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8407/testReport/ modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8407/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          .002 Missed some junit and mockito includes.

          Show
          stack stack added a comment - .002 Missed some junit and mockito includes.
          Hide
          uagashe Umesh Agashe added a comment -

          +1, nice pom clean up stack. I applied the patch locally, it builds. Compared the before and after output of command: "mvn dependency:analyze". Though there are a few warnings still present, patch cleaned up allot.

          Show
          uagashe Umesh Agashe added a comment - +1, nice pom clean up stack . I applied the patch locally, it builds. Compared the before and after output of command: "mvn dependency:analyze". Though there are a few warnings still present, patch cleaned up allot.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 3m 14s master passed
          +1 compile 9m 53s master passed
          +1 mvneclipse 7m 8s master passed
          +1 javadoc 7m 28s master passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 9m 28s the patch passed
          +1 compile 9m 11s the patch passed
          +1 javac 9m 11s the patch passed
          +1 mvneclipse 6m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 35s The patch has no ill-formed XML file.
          +1 hadoopcheck 30m 6s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 javadoc 7m 2s the patch passed
          +1 unit 0m 8s hbase-error-prone in the patch passed.
          +1 unit 0m 25s hbase-protocol-shaded in the patch passed.
          +1 unit 2m 16s hbase-common in the patch passed.
          +1 unit 0m 8s hbase-metrics-api in the patch passed.
          +1 unit 0m 20s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 16s hbase-metrics in the patch passed.
          +1 unit 0m 26s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 9s hbase-replication in the patch passed.
          +1 unit 0m 26s hbase-prefix-tree in the patch passed.
          +1 unit 2m 54s hbase-procedure in the patch passed.
          +1 unit 88m 43s hbase-server in the patch passed.
          +1 unit 8m 34s hbase-mapreduce in the patch passed.
          +1 unit 0m 16s hbase-resource-bundle in the patch passed.
          +1 unit 1m 43s hbase-thrift in the patch passed.
          +1 unit 0m 29s hbase-rsgroup in the patch passed.
          +1 unit 6m 58s hbase-shell in the patch passed.
          +1 unit 2m 34s hbase-endpoint in the patch passed.
          +1 unit 11m 0s hbase-backup in the patch passed.
          +1 unit 0m 27s hbase-it in the patch passed.
          +1 unit 0m 56s hbase-examples in the patch passed.
          +1 unit 3m 0s hbase-rest in the patch passed.
          +1 unit 0m 21s hbase-external-blockcache in the patch passed.
          +1 unit 4m 18s hbase-spark in the patch passed.
          +1 unit 0m 23s hbase-spark-it in the patch passed.
          +1 unit 0m 22s hbase-shaded in the patch passed.
          +1 unit 0m 19s hbase-shaded-check-invariants in the patch passed.
          +1 unit 0m 47s hbase-client-project in the patch passed.
          -1 unit 0m 19s root in the patch failed.
          +1 asflicense 7m 50s The patch does not generate ASF License warnings.
          239m 28s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884685/HBASE-18723.master.002.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux d4f319b1d153 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 53c9516
          Default Java 1.8.0_144
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8418/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8418/testReport/
          modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8418/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 3m 14s master passed +1 compile 9m 53s master passed +1 mvneclipse 7m 8s master passed +1 javadoc 7m 28s master passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 9m 28s the patch passed +1 compile 9m 11s the patch passed +1 javac 9m 11s the patch passed +1 mvneclipse 6m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 35s The patch has no ill-formed XML file. +1 hadoopcheck 30m 6s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 javadoc 7m 2s the patch passed +1 unit 0m 8s hbase-error-prone in the patch passed. +1 unit 0m 25s hbase-protocol-shaded in the patch passed. +1 unit 2m 16s hbase-common in the patch passed. +1 unit 0m 8s hbase-metrics-api in the patch passed. +1 unit 0m 20s hbase-hadoop-compat in the patch passed. +1 unit 0m 16s hbase-metrics in the patch passed. +1 unit 0m 26s hbase-hadoop2-compat in the patch passed. +1 unit 0m 9s hbase-replication in the patch passed. +1 unit 0m 26s hbase-prefix-tree in the patch passed. +1 unit 2m 54s hbase-procedure in the patch passed. +1 unit 88m 43s hbase-server in the patch passed. +1 unit 8m 34s hbase-mapreduce in the patch passed. +1 unit 0m 16s hbase-resource-bundle in the patch passed. +1 unit 1m 43s hbase-thrift in the patch passed. +1 unit 0m 29s hbase-rsgroup in the patch passed. +1 unit 6m 58s hbase-shell in the patch passed. +1 unit 2m 34s hbase-endpoint in the patch passed. +1 unit 11m 0s hbase-backup in the patch passed. +1 unit 0m 27s hbase-it in the patch passed. +1 unit 0m 56s hbase-examples in the patch passed. +1 unit 3m 0s hbase-rest in the patch passed. +1 unit 0m 21s hbase-external-blockcache in the patch passed. +1 unit 4m 18s hbase-spark in the patch passed. +1 unit 0m 23s hbase-spark-it in the patch passed. +1 unit 0m 22s hbase-shaded in the patch passed. +1 unit 0m 19s hbase-shaded-check-invariants in the patch passed. +1 unit 0m 47s hbase-client-project in the patch passed. -1 unit 0m 19s root in the patch failed. +1 asflicense 7m 50s The patch does not generate ASF License warnings. 239m 28s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884685/HBASE-18723.master.002.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux d4f319b1d153 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 53c9516 Default Java 1.8.0_144 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8418/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8418/testReport/ modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8418/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          .003 Put junit back in parent pom for now. Filed new issue to work on fixing our build so test is not run in all modules (lots of modules have no tests).

          Show
          stack stack added a comment - .003 Put junit back in parent pom for now. Filed new issue to work on fixing our build so test is not run in all modules (lots of modules have no tests).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 3m 35s master passed
          +1 compile 10m 28s master passed
          +1 mvneclipse 7m 29s master passed
          +1 javadoc 7m 35s master passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 11m 0s the patch passed
          +1 compile 10m 28s the patch passed
          +1 javac 10m 28s the patch passed
          +1 mvneclipse 7m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 33s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 javadoc 7m 43s the patch passed
          +1 unit 0m 8s hbase-error-prone in the patch passed.
          +1 unit 0m 25s hbase-protocol-shaded in the patch passed.
          +1 unit 2m 16s hbase-common in the patch passed.
          +1 unit 0m 10s hbase-metrics-api in the patch passed.
          +1 unit 0m 21s hbase-hadoop-compat in the patch passed.
          +1 unit 0m 16s hbase-metrics in the patch passed.
          +1 unit 0m 25s hbase-hadoop2-compat in the patch passed.
          +1 unit 0m 10s hbase-replication in the patch passed.
          +1 unit 0m 24s hbase-prefix-tree in the patch passed.
          +1 unit 2m 58s hbase-procedure in the patch passed.
          +1 unit 108m 9s hbase-server in the patch passed.
          +1 unit 9m 31s hbase-mapreduce in the patch passed.
          +1 unit 0m 13s hbase-resource-bundle in the patch passed.
          +1 unit 1m 59s hbase-thrift in the patch passed.
          +1 unit 0m 28s hbase-rsgroup in the patch passed.
          +1 unit 12m 2s hbase-shell in the patch passed.
          +1 unit 3m 26s hbase-endpoint in the patch passed.
          +1 unit 9m 39s hbase-backup in the patch passed.
          +1 unit 0m 37s hbase-it in the patch passed.
          +1 unit 1m 3s hbase-examples in the patch passed.
          +1 unit 4m 18s hbase-rest in the patch passed.
          +1 unit 0m 20s hbase-external-blockcache in the patch passed.
          +1 unit 4m 26s hbase-spark in the patch passed.
          +1 unit 0m 22s hbase-spark-it in the patch passed.
          +1 unit 0m 23s hbase-shaded in the patch passed.
          +1 unit 0m 20s hbase-shaded-check-invariants in the patch passed.
          +1 unit 0m 53s hbase-client-project in the patch passed.
          +1 unit 174m 55s root in the patch passed.
          +1 asflicense 6m 48s The patch does not generate ASF License warnings.
          449m 26s



          Subsystem Report/Notes
          Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884775/HBASE-18723.master.003.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux a3b6ae41700e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 8a800c3
          Default Java 1.8.0_144
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8419/testReport/
          modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8419/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 3m 35s master passed +1 compile 10m 28s master passed +1 mvneclipse 7m 29s master passed +1 javadoc 7m 35s master passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 11m 0s the patch passed +1 compile 10m 28s the patch passed +1 javac 10m 28s the patch passed +1 mvneclipse 7m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 33s The patch has no ill-formed XML file. +1 hadoopcheck 33m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 javadoc 7m 43s the patch passed +1 unit 0m 8s hbase-error-prone in the patch passed. +1 unit 0m 25s hbase-protocol-shaded in the patch passed. +1 unit 2m 16s hbase-common in the patch passed. +1 unit 0m 10s hbase-metrics-api in the patch passed. +1 unit 0m 21s hbase-hadoop-compat in the patch passed. +1 unit 0m 16s hbase-metrics in the patch passed. +1 unit 0m 25s hbase-hadoop2-compat in the patch passed. +1 unit 0m 10s hbase-replication in the patch passed. +1 unit 0m 24s hbase-prefix-tree in the patch passed. +1 unit 2m 58s hbase-procedure in the patch passed. +1 unit 108m 9s hbase-server in the patch passed. +1 unit 9m 31s hbase-mapreduce in the patch passed. +1 unit 0m 13s hbase-resource-bundle in the patch passed. +1 unit 1m 59s hbase-thrift in the patch passed. +1 unit 0m 28s hbase-rsgroup in the patch passed. +1 unit 12m 2s hbase-shell in the patch passed. +1 unit 3m 26s hbase-endpoint in the patch passed. +1 unit 9m 39s hbase-backup in the patch passed. +1 unit 0m 37s hbase-it in the patch passed. +1 unit 1m 3s hbase-examples in the patch passed. +1 unit 4m 18s hbase-rest in the patch passed. +1 unit 0m 20s hbase-external-blockcache in the patch passed. +1 unit 4m 26s hbase-spark in the patch passed. +1 unit 0m 22s hbase-spark-it in the patch passed. +1 unit 0m 23s hbase-shaded in the patch passed. +1 unit 0m 20s hbase-shaded-check-invariants in the patch passed. +1 unit 0m 53s hbase-client-project in the patch passed. +1 unit 174m 55s root in the patch passed. +1 asflicense 6m 48s The patch does not generate ASF License warnings. 449m 26s Subsystem Report/Notes Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884775/HBASE-18723.master.003.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux a3b6ae41700e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 8a800c3 Default Java 1.8.0_144 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8419/testReport/ modules C: hbase-build-support/hbase-error-prone hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-replication hbase-prefix-tree hbase-procedure hbase-server hbase-mapreduce hbase-resource-bundle hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-backup hbase-it hbase-examples hbase-rest hbase-external-blockcache hbase-spark hbase-spark-it hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-archetypes/hbase-client-project . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8419/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          Pushed to master.

          Show
          stack stack added a comment - Pushed to master.
          Hide
          Apache9 Duo Zhang added a comment -

          stack No branch-2 sir?

          Show
          Apache9 Duo Zhang added a comment - stack No branch-2 sir?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3636 (See https://builds.apache.org/job/HBase-Trunk_matrix/3636/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev fb537fe73695db4f648ec4f1fd54a99fa282bded)

          • (edit) hbase-metrics/pom.xml
          • (edit) hbase-shell/pom.xml
          • (edit) hbase-external-blockcache/pom.xml
          • (edit) hbase-common/pom.xml
          • (edit) hbase-replication/pom.xml
          • (edit) hbase-resource-bundle/pom.xml
          • (edit) hbase-hadoop-compat/pom.xml
          • (edit) hbase-shaded/pom.xml
          • (edit) hbase-hadoop2-compat/pom.xml
          • (edit) hbase-rsgroup/pom.xml
          • (edit) pom.xml
          • (edit) hbase-shaded/hbase-shaded-check-invariants/pom.xml
          • (edit) hbase-thrift/pom.xml
          • (edit) hbase-build-support/hbase-error-prone/pom.xml
          • (edit) hbase-archetypes/hbase-client-project/pom.xml
          • (edit) hbase-server/pom.xml
          • (edit) hbase-spark/pom.xml
          • (edit) hbase-procedure/pom.xml
          • (edit) hbase-endpoint/pom.xml
          • (edit) hbase-protocol-shaded/pom.xml
          • (edit) hbase-backup/pom.xml
          • (edit) hbase-it/pom.xml
          • (edit) hbase-metrics-api/pom.xml
          • (edit) hbase-examples/pom.xml
          • (edit) hbase-spark-it/pom.xml
          • (edit) hbase-prefix-tree/pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) hbase-mapreduce/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3636 (See https://builds.apache.org/job/HBase-Trunk_matrix/3636/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev fb537fe73695db4f648ec4f1fd54a99fa282bded) (edit) hbase-metrics/pom.xml (edit) hbase-shell/pom.xml (edit) hbase-external-blockcache/pom.xml (edit) hbase-common/pom.xml (edit) hbase-replication/pom.xml (edit) hbase-resource-bundle/pom.xml (edit) hbase-hadoop-compat/pom.xml (edit) hbase-shaded/pom.xml (edit) hbase-hadoop2-compat/pom.xml (edit) hbase-rsgroup/pom.xml (edit) pom.xml (edit) hbase-shaded/hbase-shaded-check-invariants/pom.xml (edit) hbase-thrift/pom.xml (edit) hbase-build-support/hbase-error-prone/pom.xml (edit) hbase-archetypes/hbase-client-project/pom.xml (edit) hbase-server/pom.xml (edit) hbase-spark/pom.xml (edit) hbase-procedure/pom.xml (edit) hbase-endpoint/pom.xml (edit) hbase-protocol-shaded/pom.xml (edit) hbase-backup/pom.xml (edit) hbase-it/pom.xml (edit) hbase-metrics-api/pom.xml (edit) hbase-examples/pom.xml (edit) hbase-spark-it/pom.xml (edit) hbase-prefix-tree/pom.xml (edit) hbase-rest/pom.xml (edit) hbase-mapreduce/pom.xml
          Hide
          stack stack added a comment -

          stack No branch-2 sir?

          I forgot! Thanks for the kick.

          Show
          stack stack added a comment - stack No branch-2 sir? I forgot! Thanks for the kick.
          Hide
          stack stack added a comment -

          Pushed to branch-2. Thanks Duo Zhang

          Show
          stack stack added a comment - Pushed to branch-2. Thanks Duo Zhang
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #437 (See https://builds.apache.org/job/HBase-2.0/437/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 43c4bc57618e3ede14f4964704ad753c27253e61)

          • (edit) hbase-it/pom.xml
          • (edit) hbase-resource-bundle/pom.xml
          • (edit) hbase-thrift/pom.xml
          • (edit) hbase-endpoint/pom.xml
          • (edit) pom.xml
          • (edit) hbase-hadoop-compat/pom.xml
          • (edit) hbase-external-blockcache/pom.xml
          • (edit) hbase-archetypes/hbase-client-project/pom.xml
          • (edit) hbase-protocol-shaded/pom.xml
          • (edit) hbase-examples/pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) hbase-spark-it/pom.xml
          • (edit) hbase-metrics/pom.xml
          • (edit) hbase-server/pom.xml
          • (edit) hbase-hadoop2-compat/pom.xml
          • (edit) hbase-backup/pom.xml
          • (edit) hbase-prefix-tree/pom.xml
          • (edit) hbase-common/pom.xml
          • (edit) hbase-rsgroup/pom.xml
          • (edit) hbase-spark/pom.xml
          • (edit) hbase-procedure/pom.xml
          • (edit) hbase-shaded/pom.xml
          • (edit) hbase-replication/pom.xml
          • (edit) hbase-mapreduce/pom.xml
          • (edit) hbase-shaded/hbase-shaded-check-invariants/pom.xml
          • (edit) hbase-metrics-api/pom.xml
          • (edit) hbase-shell/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #437 (See https://builds.apache.org/job/HBase-2.0/437/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 43c4bc57618e3ede14f4964704ad753c27253e61) (edit) hbase-it/pom.xml (edit) hbase-resource-bundle/pom.xml (edit) hbase-thrift/pom.xml (edit) hbase-endpoint/pom.xml (edit) pom.xml (edit) hbase-hadoop-compat/pom.xml (edit) hbase-external-blockcache/pom.xml (edit) hbase-archetypes/hbase-client-project/pom.xml (edit) hbase-protocol-shaded/pom.xml (edit) hbase-examples/pom.xml (edit) hbase-rest/pom.xml (edit) hbase-spark-it/pom.xml (edit) hbase-metrics/pom.xml (edit) hbase-server/pom.xml (edit) hbase-hadoop2-compat/pom.xml (edit) hbase-backup/pom.xml (edit) hbase-prefix-tree/pom.xml (edit) hbase-common/pom.xml (edit) hbase-rsgroup/pom.xml (edit) hbase-spark/pom.xml (edit) hbase-procedure/pom.xml (edit) hbase-shaded/pom.xml (edit) hbase-replication/pom.xml (edit) hbase-mapreduce/pom.xml (edit) hbase-shaded/hbase-shaded-check-invariants/pom.xml (edit) hbase-metrics-api/pom.xml (edit) hbase-shell/pom.xml
          Hide
          stack stack added a comment -

          Reopening for addendum. Still holes in dependency. See latest runs of HBASE-18674

          Show
          stack stack added a comment - Reopening for addendum. Still holes in dependency. See latest runs of HBASE-18674
          Hide
          stack stack added a comment -

          Here is an addendum that comes of wrestling maven depdendency:analyze, hadoop exclusions and study of failures over on HBASE-18674. Lets see what this is like.

          Cycle will be commit addendum, run HBASE-18674, find more holes, commit more here... but hopefully I got it this time.

          Show
          stack stack added a comment - Here is an addendum that comes of wrestling maven depdendency:analyze, hadoop exclusions and study of failures over on HBASE-18674 . Lets see what this is like. Cycle will be commit addendum, run HBASE-18674 , find more holes, commit more here... but hopefully I got it this time.
          Hide
          stack stack added a comment -

          .addendum More explicit includes of depdendencies (and removal of unused) in hbase-backup, hbase-mapreduce, and in hbase-rest.

          Show
          stack stack added a comment - .addendum More explicit includes of depdendencies (and removal of unused) in hbase-backup, hbase-mapreduce, and in hbase-rest.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 21s Maven dependency ordering for branch
          +1 mvninstall 4m 15s master passed
          +1 compile 4m 40s master passed
          +1 mvneclipse 2m 49s master passed
          +1 javadoc 3m 46s master passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          -1 mvninstall 0m 18s hbase-rest in the patch failed.
          -1 mvninstall 3m 55s root in the patch failed.
          -1 compile 0m 21s hbase-rest in the patch failed.
          -1 compile 2m 7s root in the patch failed.
          -1 javac 0m 21s hbase-rest in the patch failed.
          -1 javac 2m 7s root in the patch failed.
          +1 mvneclipse 2m 47s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          -1 hadoopcheck 2m 31s The patch causes 24 errors with Hadoop v2.6.1.
          -1 hadoopcheck 4m 54s The patch causes 24 errors with Hadoop v2.6.2.
          -1 hadoopcheck 7m 17s The patch causes 24 errors with Hadoop v2.6.3.
          -1 hadoopcheck 9m 41s The patch causes 24 errors with Hadoop v2.6.4.
          -1 hadoopcheck 12m 8s The patch causes 24 errors with Hadoop v2.6.5.
          -1 hadoopcheck 14m 30s The patch causes 24 errors with Hadoop v2.7.1.
          -1 hadoopcheck 16m 56s The patch causes 24 errors with Hadoop v2.7.2.
          -1 hadoopcheck 19m 19s The patch causes 24 errors with Hadoop v2.7.3.
          -1 hadoopcheck 21m 44s The patch causes 24 errors with Hadoop v3.0.0-alpha4.
          +1 javadoc 3m 46s the patch passed
          +1 unit 10m 25s hbase-mapreduce in the patch passed.
          +1 unit 9m 40s hbase-backup in the patch passed.
          -1 unit 0m 20s hbase-rest in the patch failed.
          -1 unit 76m 35s root in the patch failed.
          +1 asflicense 1m 54s The patch does not generate ASF License warnings.
          152m 15s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure
            org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure
            org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
            org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries
            org.apache.hadoop.hbase.TestHBaseTestingUtility
            org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
            org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint
            org.apache.hadoop.hbase.wal.TestWALFiltering
            org.apache.hadoop.hbase.master.TestGetInfoPort
            org.apache.hadoop.hbase.wal.TestWALSplitCompressed
            org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
            org.apache.hadoop.hbase.quotas.TestRegionSizeUse
            org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput
            org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
            org.apache.hadoop.hbase.master.TestMasterMetrics
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner
            org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
            org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
            org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput
            org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport
            org.apache.hadoop.hbase.TestClusterBootOrder
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
            org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
            org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders
            org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
            org.apache.hadoop.hbase.master.TestMasterShutdown
            org.apache.hadoop.hbase.security.TestSecureIPC
            org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL
            org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner
            org.apache.hadoop.hbase.TestAcidGuarantees
            org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
            org.apache.hadoop.hbase.TestGlobalMemStoreSize
            org.apache.hadoop.hbase.master.assignment.TestRegionStates
            org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
            org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter
            org.apache.hadoop.hbase.client.TestEnableTable
            org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
            org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication
            org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache
            org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster
            org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports
            org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
            org.apache.hadoop.hbase.TestIOFencing
            org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
            org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
            org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions
            org.apache.hadoop.hbase.TestLocalHBaseCluster
            org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite
            org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
            org.apache.hadoop.hbase.master.TestMasterFileSystem
            org.apache.hadoop.hbase.regionserver.TestClusterId
            org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
            org.apache.hadoop.hbase.client.TestTableSnapshotScanner
            org.apache.hadoop.hbase.fs.TestBlockReorder
            org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
            org.apache.hadoop.hbase.util.TestConnectionCache
            org.apache.hadoop.hbase.io.hfile.TestHFileBlock
            org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
            org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy
            org.apache.hadoop.hbase.wal.TestWALFactory
            org.apache.hadoop.hbase.regionserver.TestStore
            org.apache.hadoop.hbase.wal.TestFSHLogProvider
            org.apache.hadoop.hbase.util.TestIdReadWriteLock
            org.apache.hadoop.hbase.client.TestAsyncAdminBuilder
            org.apache.hadoop.hbase.regionserver.TestAtomicOperation
            org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
            org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure
            org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
            org.apache.hadoop.hbase.io.TestFileLink
            org.apache.hadoop.hbase.util.TestFSUtils
            org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder
            org.apache.hadoop.hbase.regionserver.TestMajorCompaction
            org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2
            org.apache.hadoop.hbase.wal.TestWALSplit
            org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885099/HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux f45f230a5f07 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 7c51d3f
          Default Java 1.8.0_144
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-mvninstall-hbase-rest.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-hbase-rest.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-hbase-rest.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-root.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-unit-hbase-rest.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8442/testReport/
          modules C: hbase-mapreduce hbase-backup hbase-rest . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8442/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 4m 15s master passed +1 compile 4m 40s master passed +1 mvneclipse 2m 49s master passed +1 javadoc 3m 46s master passed 0 mvndep 0m 19s Maven dependency ordering for patch -1 mvninstall 0m 18s hbase-rest in the patch failed. -1 mvninstall 3m 55s root in the patch failed. -1 compile 0m 21s hbase-rest in the patch failed. -1 compile 2m 7s root in the patch failed. -1 javac 0m 21s hbase-rest in the patch failed. -1 javac 2m 7s root in the patch failed. +1 mvneclipse 2m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. -1 hadoopcheck 2m 31s The patch causes 24 errors with Hadoop v2.6.1. -1 hadoopcheck 4m 54s The patch causes 24 errors with Hadoop v2.6.2. -1 hadoopcheck 7m 17s The patch causes 24 errors with Hadoop v2.6.3. -1 hadoopcheck 9m 41s The patch causes 24 errors with Hadoop v2.6.4. -1 hadoopcheck 12m 8s The patch causes 24 errors with Hadoop v2.6.5. -1 hadoopcheck 14m 30s The patch causes 24 errors with Hadoop v2.7.1. -1 hadoopcheck 16m 56s The patch causes 24 errors with Hadoop v2.7.2. -1 hadoopcheck 19m 19s The patch causes 24 errors with Hadoop v2.7.3. -1 hadoopcheck 21m 44s The patch causes 24 errors with Hadoop v3.0.0-alpha4. +1 javadoc 3m 46s the patch passed +1 unit 10m 25s hbase-mapreduce in the patch passed. +1 unit 9m 40s hbase-backup in the patch passed. -1 unit 0m 20s hbase-rest in the patch failed. -1 unit 76m 35s root in the patch failed. +1 asflicense 1m 54s The patch does not generate ASF License warnings. 152m 15s Reason Tests Timed out junit tests org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure   org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure   org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy   org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries   org.apache.hadoop.hbase.TestHBaseTestingUtility   org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook   org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint   org.apache.hadoop.hbase.wal.TestWALFiltering   org.apache.hadoop.hbase.master.TestGetInfoPort   org.apache.hadoop.hbase.wal.TestWALSplitCompressed   org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence   org.apache.hadoop.hbase.quotas.TestRegionSizeUse   org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput   org.apache.hadoop.hbase.util.TestHBaseFsckEncryption   org.apache.hadoop.hbase.master.TestMasterMetrics   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner   org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS   org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable   org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput   org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport   org.apache.hadoop.hbase.TestClusterBootOrder   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss   org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded   org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders   org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential   org.apache.hadoop.hbase.master.TestMasterShutdown   org.apache.hadoop.hbase.security.TestSecureIPC   org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL   org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner   org.apache.hadoop.hbase.TestAcidGuarantees   org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter   org.apache.hadoop.hbase.TestGlobalMemStoreSize   org.apache.hadoop.hbase.master.assignment.TestRegionStates   org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks   org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter   org.apache.hadoop.hbase.client.TestEnableTable   org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString   org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication   org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache   org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster   org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports   org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel   org.apache.hadoop.hbase.TestIOFencing   org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing   org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes   org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions   org.apache.hadoop.hbase.TestLocalHBaseCluster   org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite   org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk   org.apache.hadoop.hbase.master.TestMasterFileSystem   org.apache.hadoop.hbase.regionserver.TestClusterId   org.apache.hadoop.hbase.regionserver.TestRegionServerHostname   org.apache.hadoop.hbase.client.TestTableSnapshotScanner   org.apache.hadoop.hbase.fs.TestBlockReorder   org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort   org.apache.hadoop.hbase.util.TestConnectionCache   org.apache.hadoop.hbase.io.hfile.TestHFileBlock   org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover   org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy   org.apache.hadoop.hbase.wal.TestWALFactory   org.apache.hadoop.hbase.regionserver.TestStore   org.apache.hadoop.hbase.wal.TestFSHLogProvider   org.apache.hadoop.hbase.util.TestIdReadWriteLock   org.apache.hadoop.hbase.client.TestAsyncAdminBuilder   org.apache.hadoop.hbase.regionserver.TestAtomicOperation   org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas   org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure   org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure   org.apache.hadoop.hbase.io.TestFileLink   org.apache.hadoop.hbase.util.TestFSUtils   org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder   org.apache.hadoop.hbase.regionserver.TestMajorCompaction   org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2   org.apache.hadoop.hbase.wal.TestWALSplit   org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885099/HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux f45f230a5f07 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 7c51d3f Default Java 1.8.0_144 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-mvninstall-hbase-rest.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-hbase-rest.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-hbase-rest.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-compile-root.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-unit-hbase-rest.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8442/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8442/testReport/ modules C: hbase-mapreduce hbase-backup hbase-rest . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8442/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          .004 Put back the removal of MR dependency into hbase-rest; PE needs it.

          Show
          stack stack added a comment - .004 Put back the removal of MR dependency into hbase-rest; PE needs it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 34s Maven dependency ordering for branch
          +1 mvninstall 3m 45s master passed
          +1 compile 4m 7s master passed
          +1 mvneclipse 2m 41s master passed
          +1 javadoc 3m 10s master passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 4m 27s the patch passed
          +1 compile 4m 7s the patch passed
          +1 javac 4m 7s the patch passed
          +1 mvneclipse 2m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 5s The patch has no ill-formed XML file.
          +1 hadoopcheck 36m 10s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 javadoc 3m 21s the patch passed
          +1 unit 10m 1s hbase-mapreduce in the patch passed.
          +1 unit 9m 44s hbase-backup in the patch passed.
          +1 unit 4m 3s hbase-rest in the patch passed.
          +1 unit 196m 42s root in the patch passed.
          +1 asflicense 1m 5s The patch does not generate ASF License warnings.
          287m 49s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885116/HBASE-18723.master.004.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux 8e549bd38f83 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 7c51d3f
          Default Java 1.8.0_144
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8445/testReport/
          modules C: hbase-mapreduce hbase-backup hbase-rest . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8445/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 3m 45s master passed +1 compile 4m 7s master passed +1 mvneclipse 2m 41s master passed +1 javadoc 3m 10s master passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 4m 27s the patch passed +1 compile 4m 7s the patch passed +1 javac 4m 7s the patch passed +1 mvneclipse 2m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. +1 hadoopcheck 36m 10s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 javadoc 3m 21s the patch passed +1 unit 10m 1s hbase-mapreduce in the patch passed. +1 unit 9m 44s hbase-backup in the patch passed. +1 unit 4m 3s hbase-rest in the patch passed. +1 unit 196m 42s root in the patch passed. +1 asflicense 1m 5s The patch does not generate ASF License warnings. 287m 49s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885116/HBASE-18723.master.004.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux 8e549bd38f83 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 7c51d3f Default Java 1.8.0_144 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8445/testReport/ modules C: hbase-mapreduce hbase-backup hbase-rest . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8445/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3653 (See https://builds.apache.org/job/HBase-Trunk_matrix/3653/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 0e95a8a0ae24b0d19b391d49794d6716a8e86bcd)

          • (edit) hbase-mapreduce/pom.xml
          • (edit) hbase-backup/pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3653 (See https://builds.apache.org/job/HBase-Trunk_matrix/3653/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 0e95a8a0ae24b0d19b391d49794d6716a8e86bcd) (edit) hbase-mapreduce/pom.xml (edit) hbase-backup/pom.xml (edit) hbase-rest/pom.xml (edit) pom.xml
          Hide
          stack stack added a comment -

          Pushed to master and branch-2. Resolving though there might be another cycle of cleanup todo yet.

          Show
          stack stack added a comment - Pushed to master and branch-2. Resolving though there might be another cycle of cleanup todo yet.
          Hide
          stack stack added a comment -

          Pushed addendum (.004) to master and branch-2.

          Show
          stack stack added a comment - Pushed addendum (.004) to master and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #451 (See https://builds.apache.org/job/HBase-2.0/451/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 91ab25b469a441904f883dd8e130af2653a2609d)

          • (edit) hbase-mapreduce/pom.xml
          • (edit) hbase-backup/pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #451 (See https://builds.apache.org/job/HBase-2.0/451/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 91ab25b469a441904f883dd8e130af2653a2609d) (edit) hbase-mapreduce/pom.xml (edit) hbase-backup/pom.xml (edit) hbase-rest/pom.xml (edit) pom.xml
          Hide
          stack stack added a comment -

          Reopen. HBASE-18674 still fails. This time it can't find the JspC that is used internally by ant task. We purge JspC transitive includes from hadoop everywhere

          Poking around, a pretty recent bundling of JspC is in glassfish. It is what jetty suggests on this page:

          http://www.eclipse.org/jetty/documentation/9.4.x/jetty-jspc-maven-plugin.html

          Our ant hackery doing precompile needs modernizing. I tried updating it but the mapping is not clean so leaving it as is for now.

          Here is the error I get from HBASE-18674. I cannot reproduce this stuff locally though I try running the yetus commands locally (maybe if I redo the whole yetus build...)

          main:
          [mkdir] Created dir: /testptch/hbase/hbase-rest/target/hbase-webapps
          [copy] Copying 1 file to /testptch/hbase/hbase-rest/target/hbase-webapps
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 3.768s
          [INFO] Finished at: Mon Sep 04 04:35:22 UTC 2017
          [INFO] Final Memory: 32M/913M
          [INFO] ------------------------------------------------------------------------
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (generate) on project hbase-rest: An Ant BuildException has occured: taskdef class org.apache.jasper.JspC cannot be found

          Show
          stack stack added a comment - Reopen. HBASE-18674 still fails. This time it can't find the JspC that is used internally by ant task. We purge JspC transitive includes from hadoop everywhere Poking around, a pretty recent bundling of JspC is in glassfish. It is what jetty suggests on this page: http://www.eclipse.org/jetty/documentation/9.4.x/jetty-jspc-maven-plugin.html Our ant hackery doing precompile needs modernizing. I tried updating it but the mapping is not clean so leaving it as is for now. Here is the error I get from HBASE-18674 . I cannot reproduce this stuff locally though I try running the yetus commands locally (maybe if I redo the whole yetus build...) main: [mkdir] Created dir: /testptch/hbase/hbase-rest/target/hbase-webapps [copy] Copying 1 file to /testptch/hbase/hbase-rest/target/hbase-webapps [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.768s [INFO] Finished at: Mon Sep 04 04:35:22 UTC 2017 [INFO] Final Memory: 32M/913M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (generate) on project hbase-rest: An Ant BuildException has occured: taskdef class org.apache.jasper.JspC cannot be found
          Hide
          stack stack added a comment -

          .005 is addendum2. Adds include of a lib that has jspc in it for the antrun jsp precompiles. Also adds to hbase-it a reference to shaded hbase-protocol. See HBASE-18674 for the failures that are showing these holes on build box (Cannot repro. locally).

          Show
          stack stack added a comment - .005 is addendum2. Adds include of a lib that has jspc in it for the antrun jsp precompiles. Also adds to hbase-it a reference to shaded hbase-protocol. See HBASE-18674 for the failures that are showing these holes on build box (Cannot repro. locally).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 38s Maven dependency ordering for branch
          +1 mvninstall 3m 55s master passed
          +1 compile 4m 56s master passed
          +1 mvneclipse 2m 58s master passed
          +1 javadoc 3m 44s master passed
          0 mvndep 0m 21s Maven dependency ordering for patch
          +1 mvninstall 5m 37s the patch passed
          +1 compile 4m 51s the patch passed
          +1 javac 4m 51s the patch passed
          +1 mvneclipse 3m 2s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 7s The patch has no ill-formed XML file.
          +1 hadoopcheck 33m 38s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 javadoc 3m 54s the patch passed
          -1 unit 90m 28s hbase-server in the patch failed.
          +1 unit 1m 49s hbase-thrift in the patch passed.
          +1 unit 0m 25s hbase-it in the patch passed.
          +1 unit 2m 46s hbase-rest in the patch passed.
          -1 unit 100m 43s root in the patch failed.
          +1 asflicense 1m 12s The patch does not generate ASF License warnings.
          265m 47s



          Reason Tests
          Failed junit tests hadoop.hbase.tool.TestCanaryTool
            hadoop.hbase.tool.TestCanaryTool



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614
          JIRA Issue HBASE-18723
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885281/HBASE-18723.master.005.patch
          Optional Tests asflicense javac javadoc unit xml compile
          uname Linux 725601bc1aa5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / bea5de0
          Default Java 1.8.0_144
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8463/testReport/
          modules C: hbase-server hbase-thrift hbase-it hbase-rest . U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8463/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 3m 55s master passed +1 compile 4m 56s master passed +1 mvneclipse 2m 58s master passed +1 javadoc 3m 44s master passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 5m 37s the patch passed +1 compile 4m 51s the patch passed +1 javac 4m 51s the patch passed +1 mvneclipse 3m 2s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 7s The patch has no ill-formed XML file. +1 hadoopcheck 33m 38s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 javadoc 3m 54s the patch passed -1 unit 90m 28s hbase-server in the patch failed. +1 unit 1m 49s hbase-thrift in the patch passed. +1 unit 0m 25s hbase-it in the patch passed. +1 unit 2m 46s hbase-rest in the patch passed. -1 unit 100m 43s root in the patch failed. +1 asflicense 1m 12s The patch does not generate ASF License warnings. 265m 47s Reason Tests Failed junit tests hadoop.hbase.tool.TestCanaryTool   hadoop.hbase.tool.TestCanaryTool Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 JIRA Issue HBASE-18723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885281/HBASE-18723.master.005.patch Optional Tests asflicense javac javadoc unit xml compile uname Linux 725601bc1aa5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / bea5de0 Default Java 1.8.0_144 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8463/testReport/ modules C: hbase-server hbase-thrift hbase-it hbase-rest . U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8463/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          The TestCanaryTool was because of HBASE-18736; an addendum just applied should fix it. Going to push this second addendum.

          Show
          stack stack added a comment - The TestCanaryTool was because of HBASE-18736 ; an addendum just applied should fix it. Going to push this second addendum.
          Hide
          stack stack added a comment -

          Pushed addendum 2 to master and branch-2 (addendum 2 == .005 patch).

          Show
          stack stack added a comment - Pushed addendum 2 to master and branch-2 (addendum 2 == .005 patch).
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3660 (See https://builds.apache.org/job/HBase-Trunk_matrix/3660/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 52d4b25754a227983170bdbadc477756a639ea8e)

          • (edit) pom.xml
          • (edit) hbase-rest/pom.xml
          • (edit) hbase-thrift/pom.xml
          • (edit) hbase-server/pom.xml
          • (edit) hbase-it/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3660 (See https://builds.apache.org/job/HBase-Trunk_matrix/3660/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 52d4b25754a227983170bdbadc477756a639ea8e) (edit) pom.xml (edit) hbase-rest/pom.xml (edit) hbase-thrift/pom.xml (edit) hbase-server/pom.xml (edit) hbase-it/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #458 (See https://builds.apache.org/job/HBase-2.0/458/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 48bc132e12431e0369275c2d6a578e46bfd60464)

          • (edit) hbase-rest/pom.xml
          • (edit) hbase-thrift/pom.xml
          • (edit) hbase-server/pom.xml
          • (edit) hbase-it/pom.xml
          • (edit) pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #458 (See https://builds.apache.org/job/HBase-2.0/458/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 48bc132e12431e0369275c2d6a578e46bfd60464) (edit) hbase-rest/pom.xml (edit) hbase-thrift/pom.xml (edit) hbase-server/pom.xml (edit) hbase-it/pom.xml (edit) pom.xml
          Hide
          stack stack added a comment -

          Ok. Fixes for HBASE-18674 are complete. The last addendum done here seems to have fixed dependency issues for now. Leaving resolved.

          Show
          stack stack added a comment - Ok. Fixes for HBASE-18674 are complete. The last addendum done here seems to have fixed dependency issues for now. Leaving resolved.
          Hide
          uagashe Umesh Agashe added a comment -

          Thanks stack for fixing this and unblocking HBASE-18674!

          Show
          uagashe Umesh Agashe added a comment - Thanks stack for fixing this and unblocking HBASE-18674 !
          Hide
          stack stack added a comment -

          Appy found a problem where I undid hbase-server's depdency on hbase-resource-bundle. Reopening to apply below change:

          diff --git a/hbase-server/pom.xml b/hbase-server/pom.xml
          index 26100ab1fb..c1cb3a078b 100644
          — a/hbase-server/pom.xml
          +++ b/hbase-server/pom.xml
          @@ -415,6 +415,12 @@
          </dependency>
          <!-- resource bundle only needed at build time -->
          <dependency>
          + <groupId>org.apache.hbase</groupId>
          + <artifactId>hbase-resource-bundle</artifactId>
          + <version>$

          {project.version}

          </version>
          + <optional>true</optional>
          + </dependency>
          + <dependency>
          <groupId>commons-codec</groupId>
          <artifactId>commons-codec</artifactId>
          </dependency>

          Show
          stack stack added a comment - Appy found a problem where I undid hbase-server's depdency on hbase-resource-bundle. Reopening to apply below change: diff --git a/hbase-server/pom.xml b/hbase-server/pom.xml index 26100ab1fb..c1cb3a078b 100644 — a/hbase-server/pom.xml +++ b/hbase-server/pom.xml @@ -415,6 +415,12 @@ </dependency> <!-- resource bundle only needed at build time --> <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-resource-bundle</artifactId> + <version>$ {project.version} </version> + <optional>true</optional> + </dependency> + <dependency> <groupId>commons-codec</groupId> <artifactId>commons-codec</artifactId> </dependency>
          Hide
          stack stack added a comment -

          Re-resolved with ADDENDUM3 on tail of commit message:

          commit 62db6bf1a45aa33138370c744a050d6b448dec4e
          Author: Michael Stack <stack@apache.org>
          Date: Wed Sep 13 14:55:42 2017 -0700

          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit; ADDENDUM3

          diff --git a/hbase-server/pom.xml b/hbase-server/pom.xml
          index 647ea3b417..cca1a336a5 100644
          — a/hbase-server/pom.xml
          +++ b/hbase-server/pom.xml
          @@ -415,6 +415,12 @@
          </dependency>
          <!-- resource bundle only needed at build time -->
          <dependency>
          + <groupId>org.apache.hbase</groupId>
          + <artifactId>hbase-resource-bundle</artifactId>
          + <version>$

          {project.version}

          </version>
          + <optional>true</optional>
          + </dependency>
          + <dependency>
          <groupId>commons-codec</groupId>
          <artifactId>commons-codec</artifactId>
          </dependency>

          Show
          stack stack added a comment - Re-resolved with ADDENDUM3 on tail of commit message: commit 62db6bf1a45aa33138370c744a050d6b448dec4e Author: Michael Stack <stack@apache.org> Date: Wed Sep 13 14:55:42 2017 -0700 HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit; ADDENDUM3 diff --git a/hbase-server/pom.xml b/hbase-server/pom.xml index 647ea3b417..cca1a336a5 100644 — a/hbase-server/pom.xml +++ b/hbase-server/pom.xml @@ -415,6 +415,12 @@ </dependency> <!-- resource bundle only needed at build time --> <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-resource-bundle</artifactId> + <version>$ {project.version} </version> + <optional>true</optional> + </dependency> + <dependency> <groupId>commons-codec</groupId> <artifactId>commons-codec</artifactId> </dependency>
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #511 (See https://builds.apache.org/job/HBase-2.0/511/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 62db6bf1a45aa33138370c744a050d6b448dec4e)

          • (edit) hbase-server/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #511 (See https://builds.apache.org/job/HBase-2.0/511/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 62db6bf1a45aa33138370c744a050d6b448dec4e) (edit) hbase-server/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3712 (See https://builds.apache.org/job/HBase-Trunk_matrix/3712/)
          HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 8bbfc836db46336b847fe10d1bd0c9a5da8b2647)

          • (edit) hbase-server/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3712 (See https://builds.apache.org/job/HBase-Trunk_matrix/3712/ ) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 8bbfc836db46336b847fe10d1bd0c9a5da8b2647) (edit) hbase-server/pom.xml

            People

            • Assignee:
              stack stack
              Reporter:
              stack stack
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development