Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18622 Mitigate API compatibility concerns between branch-1 and branch-2
  3. HBASE-18691

[compat 1-2] HCD remove and removeConfiguration change return type

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-3, 2.0.0
    • Component/s: API
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Change made in HBASE-18008. Asking Chia-Ping Tsai if ok to undo.

      Here is complaint from JACC:

      hbase-client-1.2.6.jar, HColumnDescriptor.class
      package org.apache.hadoop.hbase
      [−] HColumnDescriptor.remove ( byte[ ] key )  :  void  1  
      org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
      Change	Effect
      1	Return value type has been changed from void to HColumnDescriptor.	This method has been removed because the return type is part of the method signature.
      
      [−] HColumnDescriptor.removeConfiguration ( String key )  :  void  1  
      org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
      Change	Effect
      1	Return value type has been changed from void to HColumnDescriptor.	This method has been removed because the return type is part of the method signature.
      
      

      Binary breaking but not src breaking. See https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking for good discussion. Probably not a prob. but just in case and if not really needed, will purge.

        Attachments

        1. HBASE-18691.v0.patch
          2 kB
          Chia-Ping Tsai

          Activity

            People

            • Assignee:
              chia7712 Chia-Ping Tsai
              Reporter:
              stack Michael Stack
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: