[HBASE-18647] Parameter cacheBlocks does not take effect in REST API for scan

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 1.4.0, 2.0.0
• Fix Version/s: 1.4.0, 2.0.0-alpha-3, 2.0.0
• Component/s: REST
• Hadoop Flags: Reviewed
• Assignee: Guangxu Cheng
• Reporter: Guangxu Cheng
• Created: 22/Aug/17 03:57
• Updated: 01/Aug/18 06:20
• Resolved: 24/Aug/17 16:45

Description

Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.

And cacheBlocks has never been used.

TableResource.java

  @Path("{scanspec: .*[*]$}")
  public TableScanResource  getScanResource(
      final @PathParam("scanspec") String scanSpec,
      @DefaultValue(Integer.MAX_VALUE + "")
      @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
      @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
      @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
      @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List<String> column,
      @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int maxVersions,
      @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int batchSize,
      @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long startTime,
      @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME) long endTime,
      @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean cacheBlocks,
      @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean reversed,
      @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String paramFilter) {