[HBASE-18473] VC.listLabels() erroneously closes any connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 2.0.0-alpha-1
• Fix Version/s: 1.4.0, 1.3.2, 2.0.0-alpha-2, 2.0.0, 1.2.7
• Component/s: Client
• Labels: beginner
• Hadoop Flags: Reviewed
• Assignee: Anoop Sam John
• Reporter: Lars George
• Created: 28/Jul/17 18:29
• Updated: 24/Jun/22 17:45
• Resolved: 30/Jul/17 10:21

Description

In HBASE-13358 the VisibilityClient.listLabels() was amended to take in a connection from the caller, which totally makes sense. But the patch forgot to remove the unconditional call to connection.close() in the finally block:

    finally {
      if (table != null) {
        table.close();
      }
      if (connection != null) {
        connection.close();
      }
    }

Remove the second if completely.

Issue Links

• is broken by: HBASE-13358 Upgrade VisibilityClient API to accept Connection object.