Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18225

Fix findbugs regression calling toString() on an array

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Looks like we got a findbugs warning as a result of HBASE-18166

      diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
      index 1d04944250..b7e0244aa2 100644
      --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
      +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
      @@ -2807,8 +2807,8 @@ public class RSRpcServices implements HBaseRPCErrorHandler,
           HRegionInfo hri = rsh.s.getRegionInfo();
           // Yes, should be the same instance
           if (regionServer.getOnlineRegion(hri.getRegionName()) != rsh.r) {
      -      String msg = "Region was re-opened after the scanner" + scannerName + " was created: "
      -          + hri.getRegionNameAsString();
      +      String msg = "Region has changed on the scanner " + scannerName + ": regionName="
      +          + hri.getRegionName() + ", scannerRegionName=" + rsh.r;
      

      Looks like hri.getRegionNameAsString() was unintentionally changed to hri.getRegionName(), Stephen Yuan Jiang/Michael Stack?

        Attachments

        1. HBASE-18225.001.patch
          1 kB
          Josh Elser

          Issue Links

            Activity

              People

              • Assignee:
                elserj Josh Elser
                Reporter:
                elserj Josh Elser
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: