Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18410 FilterList Improvement.
  3. HBASE-18160

Fix incorrect logic in FilterList.filterKeyValue

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Filters
    • Labels:
      None

      Description

      As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation:

      1. FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW is a newly added case, and the dev forgot to consider FilterList), So if a user use INCLUDE_AND_SEEK_NEXT_ROW in his own Filter and wrapped by a FilterList, it'll throw an IllegalStateException("Received code is not valid.").

      2. For FilterList with MUST_PASS_ONE, if filter-A in filter list return INCLUDE and filter-B in filter list return INCLUDE_AND_NEXT_COL, the FilterList will return INCLUDE_AND_NEXT_COL finally. According to the mininal step rule , It's incorrect. (filter list with MUST_PASS_ONE choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule).

        Attachments

        1. HBASE-18160.v8.patch
          43 kB
          Zheng Hu
        2. HBASE-18160.v7.patch
          42 kB
          Zheng Hu
        3. HBASE-18160.v6.patch
          43 kB
          Zheng Hu
        4. HBASE-18160.v6.patch
          43 kB
          Zheng Hu
        5. HBASE-18160.v5.patch
          37 kB
          Zheng Hu
        6. HBASE-18160.v4.patch
          37 kB
          Zheng Hu
        7. HBASE-18160.v3.patch
          8 kB
          Zheng Hu
        8. HBASE-18160.v2.patch
          6 kB
          Zheng Hu
        9. HBASE-18160.v2.patch
          6 kB
          Zheng Hu
        10. HBASE-18160.v1.patch
          5 kB
          Zheng Hu
        11. HBASE-18160.branch-1.4.v1.patch
          47 kB
          Zheng Hu
        12. HBASE-18160.branch-1.4.v1.patch
          47 kB
          Zheng Hu
        13. HBASE-18160.branch-1.3.v1.patch
          41 kB
          Zheng Hu
        14. HBASE-18160.branch-1.3.v1.patch
          41 kB
          Zheng Hu
        15. filter-or-map.txt
          2 kB
          Zheng Hu
        16. filter-and-map.txt
          1 kB
          Zheng Hu

          Issue Links

            Activity

              People

              • Assignee:
                openinx Zheng Hu
                Reporter:
                openinx Zheng Hu
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: