[HBASE-17862] Condition that always returns true

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.4.0, 1.2.6, 1.3.2, 1.1.11, 2.0.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: JC
• Reporter: JC
• Created: 31/Mar/17 20:28
• Updated: 06/May/17 04:56
• Resolved: 02/May/17 16:44

Description

Hi

In recent github mirror of hbase, I've found the following code smell.

Path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java

209 
210     ColumnPaginationFilter other = (ColumnPaginationFilter)o;
211     if (this.columnOffset != null) {
212       return this.getLimit() == this.getLimit() &&
213           Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
214     }

It should be?

212       return this.getLimit() == other.getLimit() &&

This might be just a code smell as Bytes.equals can be enough for the return value but wanted to report just in case.

Thanks!