Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17143 Scan improvement
  3. HBASE-17584

Expose ScanMetrics with ResultScanner rather than Scan

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 1.4.0, 2.0.0
    • Client, mapreduce, Scanners
    • None
    • Incompatible change, Reviewed
    • Hide
      Now you can use ResultScanner.getScanMetrics to get the scan metrics at any time during the scan operation. The old Scan.getScanMetrics is deprecated and still work, but if you use ResultScanner.getScanMetrics to get the scan metrics and reset it, then the metrics published to the Scan instaince will be messed up.
      Show
      Now you can use ResultScanner.getScanMetrics to get the scan metrics at any time during the scan operation. The old Scan.getScanMetrics is deprecated and still work, but if you use ResultScanner.getScanMetrics to get the scan metrics and reset it, then the metrics published to the Scan instaince will be messed up.

    Description

      I think this have been discussed many times... It is a bad practice to directly modify the Scan object passed in when calling getScanner. The reason that we can not use a copy is we need to use the Scan object to expose scan metrics. So we need to find another way to expose the metrics.

      Attachments

        1. HBASE-17584.patch
          20 kB
          Duo Zhang
        2. HBASE-17584-branch-1.patch
          15 kB
          Duo Zhang
        3. HBASE-17584-v1.patch
          18 kB
          Duo Zhang

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: