[HBASE-17118] StoreScanner leaked in KeyValueHeap

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.7, 1.2.4
• Fix Version/s: 1.4.0, 1.2.5, 1.1.8, 1.3.3, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Lijin Bin
• Reporter: Lijin Bin
• Created: 17/Nov/16 01:57
• Updated: 14/Dec/18 10:08
• Resolved: 05/Dec/16 00:46

Description

KeyValueHeap#generalizedSeek
KeyValueScanner scanner = current;
while (scanner != null) {
Cell topKey = scanner.peek();
......
boolean seekResult;
if (isLazy && heap.size() > 0)

{ // If there is only one scanner left, we don't do lazy seek. seekResult = scanner.requestSeek(seekKey, forward, useBloom); }

else

{ seekResult = NonLazyKeyValueScanner.doRealSeek(scanner, seekKey, forward); }

......
scanner = heap.poll();
}
(1) scanner = heap.poll(); Retrieves and removes the head of this queue
(2) scanner.requestSeek(seekKey, forward, useBloom); or NonLazyKeyValueScanner.doRealSeek(scanner, seekKey, forward);
throw exception, and scanner will have no chance to close, so will cause the scanner leak.

Issue Links

• relates to: HBASE-17253 backport HBASE-17118 to 1.3.x

Sub-Tasks

• backport HBASE-17118 to 1.3.x: Open