Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17118

StoreScanner leaked in KeyValueHeap

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.7, 1.2.4
    • Fix Version/s: 1.4.0, 1.2.5, 1.1.8, 1.3.3, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      KeyValueHeap#generalizedSeek
      KeyValueScanner scanner = current;
      while (scanner != null) {
      Cell topKey = scanner.peek();
      ......
      boolean seekResult;
      if (isLazy && heap.size() > 0)

      { // If there is only one scanner left, we don't do lazy seek. seekResult = scanner.requestSeek(seekKey, forward, useBloom); }

      else

      { seekResult = NonLazyKeyValueScanner.doRealSeek(scanner, seekKey, forward); }

      ......
      scanner = heap.poll();
      }
      (1) scanner = heap.poll(); Retrieves and removes the head of this queue
      (2) scanner.requestSeek(seekKey, forward, useBloom); or NonLazyKeyValueScanner.doRealSeek(scanner, seekKey, forward);
      throw exception, and scanner will have no chance to close, so will cause the scanner leak.

        Attachments

        1. StoreScannerLeakHeap.png
          306 kB
          Lijin Bin
        2. StoreScanner.png
          106 kB
          Lijin Bin
        3. HBASE-17118-master_v5.patch
          4 kB
          Lijin Bin
        4. HBASE-17118-master_v4.patch
          4 kB
          Lijin Bin
        5. HBASE-17118-master_v3.patch
          4 kB
          Lijin Bin
        6. HBASE-17118-master_v2.patch
          4 kB
          Lijin Bin
        7. HBASE-17118-master_v1.patch
          3 kB
          Lijin Bin
        8. HBASE-17118.branch-1.v1.patch
          4 kB
          Lijin Bin
        9. HBASE-17118.branch-1.addnumv1.patch
          0.6 kB
          Lijin Bin
        10. HBASE-17118.branch-1.2.v1.patch
          4 kB
          Lijin Bin
        11. HBASE-17118.branch-1.1.v1.patch
          4 kB
          Lijin Bin

          Issue Links

            Activity

              People

              • Assignee:
                binlijin Lijin Bin
                Reporter:
                binlijin Lijin Bin
              • Votes:
                0 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: