[HBASE-17096] checkAndMutateApi doesn't work correctly on 0.98.19+

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.24
• Hadoop Flags: Reviewed
• Assignee: Heng Chen
• Reporter: Samarth Jain
• Created: 15/Nov/16 03:34
• Updated: 17/Nov/16 03:57
• Resolved: 15/Nov/16 19:12

Description

Below is the test case. It uses some Phoenix APIs for getting hold of admin and HConnection but should be easily adopted for an HBase IT test. The second checkAndMutate should return false but it is returning true. This test fails with HBase-0.98.23 and works fine with HBase-0.98.17

@Test
    public void testCheckAndMutateApi() throws Exception {
        byte[] row = Bytes.toBytes("ROW");
        byte[] tableNameBytes = Bytes.toBytes(generateUniqueName());
        byte[] family = Bytes.toBytes(generateUniqueName());
        byte[] qualifier = Bytes.toBytes("QUALIFIER");
        byte[] oldValue = null;
        byte[] newValue = Bytes.toBytes("VALUE");
        Put put = new Put(row);
        put.add(family, qualifier, newValue);
        try (Connection conn = DriverManager.getConnection(getUrl())) {
            PhoenixConnection phxConn = conn.unwrap(PhoenixConnection.class);
            try (HBaseAdmin admin = phxConn.getQueryServices().getAdmin()) {
                HTableDescriptor tableDesc = new HTableDescriptor(
                        TableName.valueOf(tableNameBytes));
                HColumnDescriptor columnDesc = new HColumnDescriptor(family);
                columnDesc.setTimeToLive(120);
                tableDesc.addFamily(columnDesc);
                admin.createTable(tableDesc);
                HTableInterface tableDescriptor = admin.getConnection().getTable(tableNameBytes);
                assertTrue(tableDescriptor.checkAndPut(row, family, qualifier, oldValue, put));
                Delete delete = new Delete(row);
                RowMutations mutations = new RowMutations(row);
                mutations.add(delete);
                assertTrue(tableDescriptor.checkAndMutate(row, family, qualifier, CompareOp.EQUAL, newValue, mutations));
                assertFalse(tableDescriptor.checkAndMutate(row, family, qualifier, CompareOp.EQUAL, newValue, mutations));
            }
        }
    }

FYI, apurtell, jamestaylor, lhofhansl.

Issue Links

• is related to: HBASE-15629 Backport HBASE-14703 to 0.98+