[HBASE-17088] Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.4.0, 2.0.0
• Component/s: rpc, Scheduler
• Hadoop Flags: Reviewed
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 14/Nov/16 12:20
• Updated: 17/May/19 16:33
• Resolved: 19/Nov/16 06:33

Description

1. The RWQueueRpcExecutor has eight constructor method and the longest one has ten parameters. But It is only used in SimpleRpcScheduler and easy to confused when read the code.
2. There are duplicate method implement in RWQueueRpcExecutor and BalancedQueueRpcExecutor. They can be implemented in their parent class RpcExecutor.
3. SimpleRpcScheduler read many configs to new RpcExecutor. But the CALL_QUEUE_SCAN_SHARE_CONF_KEY is only needed by RWQueueRpcExecutor. And CALL_QUEUE_CODEL_TARGET_DELAY, CALL_QUEUE_CODEL_INTERVAL and CALL_QUEUE_CODEL_LIFO_THRESHOLD are only needed by AdaptiveLifoCoDelCallQueue.

So I thought we can refactor it. Suggestions are welcome.

Review board: https://reviews.apache.org/r/53726/