Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16964

Successfully archived files are not cleared from compacted store file list if archiving of any file fails

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 2.0.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HStore.removeCompactedFiles(), we only clear archived files from StoreFileManager's list of compactedfiles if all files were archived successfully. If we encounter an error archiving any of the files, then any files which were already archived will remain in the list of compactedfiles.

      Even worse, this means that all subsequent attempts to archive the list of compacted files will fail (as the previously successfully archived files still in the list will now throw FileNotFoundException), and the list of compactedfiles will never be cleared from that point on.

      Finally, when the region closes, we will again throw an exception out of HStore.removeCompactedFiles(), in this case causing a regionserver abort.

        Attachments

        1. HBASE-16964.patch
          19 kB
          Gary Helmling
        2. HBASE-16964.003.patch
          23 kB
          Gary Helmling
        3. HBASE-16964.002.patch
          23 kB
          Gary Helmling

          Activity

            People

            • Assignee:
              ghelmling Gary Helmling
              Reporter:
              ghelmling Gary Helmling
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: