Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16955

Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • build, Protobufs
    • None
    • Test that environment no longer has to have protoc (2.5 and 3.1) available. Needed small adjustment in yetus protoc build but otherwise all works.

    Description

      HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs are in the module they pertain to so distributed throughout the modules and secondly, we do 2.5.0 pb for externally consumed protobuf – e.g. Coprocessor Endpoints – but internally we use protobuf 3.1.0.

      A precommit check looks to see if any proto changes break protoc compile. This task is about updating the precommit to accommodate the changes brought about by HBASE-15638.

      Attachments

        1. nothing_change.txt
          0.9 kB
          Michael Stack
        2. nothing_change2.txt
          1 kB
          Michael Stack
        3. nothing_change2.txt
          1 kB
          Michael Stack
        4. nothing_change2.txt
          1 kB
          Michael Stack
        5. nothing_change2.txt
          1 kB
          Michael Stack
        6. nothing_change2.txt
          1 kB
          Michael Stack
        7. nothing_change2 (1).txt
          1 kB
          Michael Stack
        8. nothing_change2 (2).txt
          1 kB
          Michael Stack
        9. 16955.patch
          2 kB
          Michael Stack
        10. nothing_change2.txt
          1 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: