Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16889

Proc-V2: verifyTables in the IntegrationTestDDLMasterFailover test after each table DDL is incorrect

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.1.7, 2.0.0
    • 1.3.0, 1.2.4, 1.1.8, 2.0.0
    • proc-v2
    • None
    • Reviewed

    Description

      In the IntegrationTestDDLMasterFailover test, verifyTables is called after each table DDL. It iterates 3 lists of tables in ConcurrentHashMap (enabledTables, disabledTables, deletedTables) and tries to do some verification. This is incorrect, eg. a table in enabledTables map could be picked up by DeleteTableAction and is disabled, while the verification tries to check whether table is enabled. This leads to false assertion.

      The same for verifyNamespaces().

      The proposed fix is to verify maps only at the end of tests (while no active DDL operation is going on). During test run, we only verify the target table before putting into map.

      Attachments

        1. HBASE-16889.v1-branch-1.1.patch
          8 kB
          Stephen Yuan Jiang
        2. HBASE-16889.v1-master.patch
          10 kB
          Stephen Yuan Jiang

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            syuanjiang Stephen Yuan Jiang
            syuanjiang Stephen Yuan Jiang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment