Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16783 Use ByteBufferPool for the header and message during Rpc response
  3. HBASE-16859

Use Bytebuffer pool for non java clients specifically for scans/gets

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In case of non java clients we still write the results and header into a on demand byte[]. This can be changed to use the BBPool (onheap or offheap buffer?).
      But the basic problem is to identify if the response is for scans/gets.

      • One easy way to do it is use the MethodDescriptor per Call and use the name of the MethodDescriptor to identify it is a scan/get. But this will pollute RpcServer by checking for scan/get type response.
      • Other way is always set the result to cellScanner but we know that isClientCellBlockSupported is going to false for non PB clients. So ignore the cellscanner and go ahead with the results in PB. But this is not clean
      • third one is that we already have a RpccallContext being passed to the RS. In case of scan/gets/multiGets we already set a Rpccallback for shipped call. So here on response we can check if the callback is not null and check for isclientBlockSupported. In this case we can get the BB from the pool and write the result and header to that BB. May be this looks clean?

        Attachments

        1. HBASE-16859_V1.patch
          27 kB
          ramkrishna.s.vasudevan
        2. HBASE-16859_V2.patch
          21 kB
          ramkrishna.s.vasudevan
        3. HBASE-16859_V2.patch
          21 kB
          ramkrishna.s.vasudevan
        4. HBASE-16859_V4.patch
          30 kB
          ramkrishna.s.vasudevan
        5. HBASE-16859_V5.patch
          26 kB
          ramkrishna.s.vasudevan
        6. HBASE-16859_V6.patch
          26 kB
          ramkrishna.s.vasudevan
        7. HBASE-16859_V7.patch
          25 kB
          ramkrishna.s.vasudevan

          Issue Links

            Activity

              People

              • Assignee:
                ram_krish ramkrishna.s.vasudevan
                Reporter:
                ram_krish ramkrishna.s.vasudevan
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: