Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16769

Deprecate/remove PB references from MasterObserver and RegionServerObserver

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-4, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      Signature of below methods in MasterObserver changed and instead of org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotDescription param, we will be passing org.apache.hadoop.hbase.client.SnapshotDescription
      preListSnapshot
      postListSnapshot
      preSnapshot
      postSnapshot
      preCloneSnapshot
      postCloneSnapshot
      preRestoreSnapshot
      postRestoreSnapshot
      preDeleteSnapshot
      postDeleteSnapshot

      Also changed signature of RegionServerObserver#preReplicateLogEntries and preReplicateLogEntries by removing params List<org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.WALEntry>, org.apache.hadoop.hbase.CellScanner
      Show
      Signature of below methods in MasterObserver changed and instead of org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotDescription param, we will be passing org.apache.hadoop.hbase.client.SnapshotDescription preListSnapshot postListSnapshot preSnapshot postSnapshot preCloneSnapshot postCloneSnapshot preRestoreSnapshot postRestoreSnapshot preDeleteSnapshot postDeleteSnapshot Also changed signature of RegionServerObserver#preReplicateLogEntries and preReplicateLogEntries by removing params List<org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.WALEntry>, org.apache.hadoop.hbase.CellScanner

      Description

      This is effectively a sub-task for HBASE-15174.
      CP Methods
      MasterObserver
      preListSnapshot
      postListSnapshot
      preSnapshot
      postSnapshot
      preCloneSnapshot
      postCloneSnapshot
      preRestoreSnapshot
      postRestoreSnapshot
      preDeleteSnapshot
      postDeleteSnapshot

      preSetUserQuota
      postSetUserQuota
      preSetUserQuota
      postSetUserQuota
      preSetUserQuota
      postSetUserQuota
      preSetTableQuota
      postSetTableQuota
      preSetNamespaceQuota
      postSetNamespaceQuota

      RegionServerObserver
      preReplicateLogEntries
      postReplicateLogEntries

      Note : This issue not handling Quota related CPs. Same is handled by a subtask here HBase-18807

        Attachments

        1. HBASE-16769.patch
          32 kB
          Anoop Sam John
        2. HBASE-16769_V2.patch
          32 kB
          Anoop Sam John
        3. HBASE-16769_V4.patch
          33 kB
          Anoop Sam John

          Issue Links

            Activity

              People

              • Assignee:
                anoop.hbase Anoop Sam John
                Reporter:
                anoop.hbase Anoop Sam John
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: