[HBASE-16743] TestSimpleRpcScheduler#testCoDelScheduling is broke

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: rpc
• Assignee: Mikhail Antonov
• Reporter: Michael Stack
• Created: 30/Sep/16 23:55
• Updated: 06/Apr/18 04:33
• Resolved: 28/Oct/16 23:50

Description

The testCoDelScheduling test is broke. Here are some notes on it. I have disabled it in the HBASE-15638 shading patch.

I don't get this test. When I time this test, the minDelay is > 2 * codel delay from the get go. So we are always overloaded. The test below would seem to complete the queuing of all the CallRunners inside the codel check interval. I don't think we are skipping codel checking. Second, I think this test has been  broken since HBASE-16089 Add on FastPath for CoDel went in. The thread name we were looking for was the name BEFORE we updated: i.e. "RpcServer.CodelBQ.default.handler". But same patch changed the name of the codel  fastpath thread to: new FastPathBalancedQueueRpcExecutor("CodelFPBQ.default", handlerCount, numCallQueues...

Codel is hard to test. This test is going to be flakey given it all timer-based. Disabling for now till chat

FYI mantonov