Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15638 Shade protobuf
  3. HBASE-16741

Amend the generate protobufs out-of-band build step to include shade, pulling in protobuf source and a hook for patching protobuf

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Protobufs
    • Labels:
      None

      Description

      As part of the protobuf shading work, I need to amend the build step that builds protobuf sources. For the module used by hbase internally – the one that has our protos and that does the protobuf shading – I need to enhance the generate protobuf sources step to also do:

      • Shading/relocating so we avoid clashing with protos used by CPEPs out in the hbase-protocol module.
      • Pulling down the protobuf lib and including its sources to make IDEs happy else they'll moan about missing (shaded) protobuf.
      • A hook that allows us to patch protobuf lib, at least temporarily until our needed changes make it upstream.

        Attachments

        1. 16741.patch
          8.63 MB
          Michael Stack

          Issue Links

            Activity

              People

              • Assignee:
                stack Michael Stack
                Reporter:
                stack Michael Stack
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: