[HBASE-16699] Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0, 2.0.0
• Fix Version/s: 1.3.0, 1.2.4, 1.1.8, 2.0.0
• Assignee: Hua Xiang
• Reporter: Hua Xiang
• Created: 23/Sep/16 21:02
• Updated: 09/Nov/17 01:40
• Resolved: 10/Oct/16 21:34

Description

It seems that there are more overflow in other places, and a concurrent issue.
I will post a patch within one or 2 days after I figure out adding new unittest cases.

Please see the following two lines. Once it overflows, it will cause wrong behavior. For unconfigured RateLimiters, we should have simpler logic to byPass the check.

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51

Issue Links

• links to: Review Board (master)