Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16699

Overflows in AverageIntervalRateLimiter's refill() and getWaitInterval()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0, 2.0.0
    • Fix Version/s: 1.3.0, 1.2.4, 1.1.8, 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      It seems that there are more overflow in other places, and a concurrent issue.
      I will post a patch within one or 2 days after I figure out adding new unittest cases.

      Please see the following two lines. Once it overflows, it will cause wrong behavior. For unconfigured RateLimiters, we should have simpler logic to byPass the check.

      https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L37

      https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/AverageIntervalRateLimiter.java#L51

        Attachments

        1. HBASE-16699.master.001.patch
          22 kB
          Hua Xiang
        2. HBASE-16699.master.002.patch
          21 kB
          Hua Xiang
        3. HBASE-16699.branch-1.001.patch
          21 kB
          Hua Xiang

          Issue Links

            Activity

              People

              • Assignee:
                huaxiang Hua Xiang
                Reporter:
                huaxiang Hua Xiang
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: