[HBASE-16613] Return the unused ByteBuffer to BoundedByteBufferPool when no cell is retrieved from the CellScanner

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0, 1.2.4
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 12/Sep/16 07:05
• Updated: 09/Nov/17 01:34
• Resolved: 14/Sep/16 20:21

Description

The critical code is shown below:

IPCUtil.java

// We should put the ByteBuffer into pool before return null
  public ByteBuffer buildCellBlock(final Codec codec, final CompressionCodec compressor,
    final CellScanner cellScanner, final BoundedByteBufferPool pool) {
  ...
  if (pool != null) {
      ByteBuffer bb = pool.getBuffer();
      bufferSize = bb.capacity();
      baos = new ByteBufferOutputStream(bb);
  }
  ...
      int count = 0;
      while (cellScanner.advance()) {
        encoder.write(cellScanner.current());
        count++;
      }
      encoder.flush();
      if (count == 0) return null;
}